Fix/required asterisk screen reader - #75
Open
nonprofittechy wants to merge 1 commit into
Open
Conversation
The red asterisk on required fields was generated with CSS ::before and ::after content, which screen readers announce literally as "star". The required state is already conveyed with aria-required, so the asterisk should be hidden from assistive technology. Emit the asterisk as a real <span class="darequiredmarker" aria-hidden="true"> element in the places where the stylesheet used to draw it, and change the CSS rules to target that span instead of the pseudo elements. Positioning, colors, dark mode, media queries, and the greyedout and dawide overrides are unchanged, so the appearance is the same. Fixes #43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is redundant since the proper aria-required is already set. fix #43