Fix 'reference to a variable html' error on interview load - #1096
Merged
Conversation
`modules:` performs `from <module> import *`, which never binds the module name itself, so `html.escape(...)` and `json.dumps(...)` in the al_menu_items_default_items block raised "reference to a variable 'html' that could not be looked up". `imports:` does `import <module>`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since #1095 (
1f7b7cb), loading any interview that includesal_visual.ymlfails with:Cause
That PR added:
In docassemble,
modules:performsfrom <module> import *. That pulls in the module's public names (escape,unescape,dumps, ...) but never binds the module name itself. So thehtml.escape(...)call in theal_menu_items_default_itemsdata from codeblock had nohtmlin scope, and docassemble tried to resolve it as an interview variable.json.dumpswould have failed the same way right after.Fix
Use
imports:, which doesimport <module>— matching howql_baseline.ymlandal_settings.ymlalready importhumanizeandimportlib.🤖 Generated with Claude Code