Updated navigation - see past filings, new from menu - #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #118, fix #153, fix #154
What this adds
Navigation from anywhere (#118). Every signed-in screen, mid-filing included, now carries a menu: Start a new case, File into an existing case, My draft e-filings, My cases, My filing plans, Filing home. Both "start" items post to one new view (
start_filing) that makes a new draft with the path already chosen and goes straight to Upload documents, so the menu is also the way out of a filing you no longer want. The profile menu keeps the account controls.My draft e-filings (#153). A filer can finally see the drafts they have: case title/number, court, new vs. existing, which step it stopped at, how many documents, when they last touched it, and which one they are currently in. Each can be continued (that specific one, not "the newest") or thrown away. "Continue a draft" on the landing page routes here when there is more than one.
Filing details, from the court's own record (#154). "My cases" is now grouped by case and server-rendered, and each filing links to a detail page showing the clerk's rejection comment, the documents with download links, fees or fee waiver, and the clerk's contact details where a partner has configured them.
We are not storing filed documents. The EFSP hands back Tyler's own links (
documentRendition[].documentRenditionMetadata.documentAttachment[].binaryLocationURI), labelled by what each copy is — "The copy you sent" vs. "The court's file-stamped copy" — and they expire 90 days after filing, which the page says out loud. Rejection comments come fromfilingLeadDocument[].documentStatus.statusText(taggedRejectComments). Case-level document retrieval is not available at all: the proxy returns 405 for it, because Tyler does not support it. Court contact details are in no code list either, so they come from an optionalcontact:block in the partner YAML, falling back to the jurisdiction help line — nothing invented.Archiving (#154 follow-on). An attorney with hundreds of filings can archive a case so it stops leading the list, and still see archived cases behind a toggle. The court's record is untouched; a new
ArchivedCaserow is all we keep.What this deletes, and why
The second commit removes ~8,800 lines across 40 files. Nothing removed was reachable from the running app.
Dead because of this PR
create_draft_view+/jurisdiction/<j>/drafts/start_filing, and nothing else ever called it. Its tests moved ontostart_filing, including a new one for the "signed into Django but not into Tyler" guard.makeNewDraft(), its error box, andgoToExpertForminoptions.htmlcontinueDraftFiling()— the expert form it was named after has been gone a long time, and continuing a draft is all it still did.css/view_statuses.css.option-card), byte-identical to the one inoptions.css. Both pages loadoptions.cssnow.Screens retired earlier, whose code was still in the tree
views/expert_form.py,views/upload.py, andviews/upload_first.pyhad no route and no importer — their URLs have redirected into the current workflow for a while, vialegacy_workflow_redirect. Deleting them made a chain of things unreachable, all deleted with them:expert_form.html,upload.html,upload_first.html, and thesearch_dropdown.htmlcomponent nothing included.cascading-dropdowns.js,form-validation.js,dynamic-form-sections.js,expert-form-main.js,upload-handler.js,upload-handler-first.js,components/search-dropdown.js,expert_form.css,upload.css,components/search-dropdown.css.save_upload_first_dataandsave_upload_data_to_session, their routes, and the twoapiUtilsmethods that called them. Uploading now goes through theupload_documentsandorganize_documentsviews. (get_upload_data_from_sessionstays — the payment screen reads it.)Obsolete API surface
create_filing,get_filing_detail,update_filing, anddelete_filinginapi/filing_views.pyall calledhttps://suffolkefile.com, a host this app does not talk to, and no screen or test called them. The file's own "this file doesn't work in its current state" TODO went with them; what is left (get_filings,payment_fees,list_filing_data) is what the app actually uses. Filing details now come from the EFSP throughservices/filings.py.Also gone: the duplicate route
api/debug-session-data/, which shared a URL name withapi/debug-session/, soreverse()only ever resolved to one of the pair.Tests that tested deleted code
expert-form-*.spec.jsPlaywright specs. They were already broken before this PR — they look for a "File a New Case" heading and aselect#courtthat no longer exist.js-tests/cascading-dropdowns.test.js, whose module is gone.test_integration.py'sTestJavaScriptFileStructure(asserted deleted JS files exist) andtest_form_page_loads(requested a URL that never existed and passed on 404 or on any exception).tests.py'stest_form_submission_validation, which POSTed to the retired expert form and accepted either 200 or 302.test_durable_drafts.py'stest_first_upload_save_uses_current_draft_jurisdiction. It reached the first-upload view through the duplicatedsave_upload_data_to_sessionURL name; both the view and the duplicate name are gone, and the live path's jurisdiction handling is covered where uploads actually happen.Stale artifacts and docs
session_cookies.txt— a committed curl cookie jar holding an expired localhost session id. Now gitignored.static/js/README.mdwas 263 lines describing the retired expert-form architecture and four modules that no longer exist; rewritten to describe the per-screen scripts that do.reorganized-filing-matrix.spec.jsand itsRUN_FILING_MATRIX=1guard.Testing
test_navigation_menu.py,test_my_drafts.py,test_filing_history.py, plus plan deletion), along with ruff, djlint,ty, and thenode --testJS suites.Notes
reorganized-filing-matrix.spec.jsis updated for the new start-a-filing flow.fetch-party-type,save-party-type, the S3 and auth JSON endpoints,case-type-config), but they are not obsoleted by this work and some carry tests, so they were left alone.