Fix names: replace 500 ms polling timer with push-based debounce - #13206
Open
ivandrofly wants to merge 1 commit into
Open
Fix names: replace 500 ms polling timer with push-based debounce#13206ivandrofly wants to merge 1 commit into
ivandrofly wants to merge 1 commit into
Conversation
ivandrofly
force-pushed
the
refactor/fix-names-push-debounce
branch
2 times, most recently
from
August 4, 2026 13:28
3ef78dd to
112bc3e
Compare
…Source Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ivandrofly
force-pushed
the
refactor/fix-names-push-debounce
branch
from
August 4, 2026 13:32
112bc3e to
95dcbb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
System.Timers.Timerpolling loop inFixNamesViewModelwith a push-based debounce (CancellationTokenSource+Task.Delay). The old timer fired every 500 ms for the entire lifetime of the window, re-joining the checked names into a string on each tick just to detect whether anything changed — even while the user did nothing. Preview generation is now only scheduled when a checkbox actually changes, and rapid toggles collapse into a single regeneration 500 ms after the last change.IsCheckedbinding withUpdateSourceTrigger.PropertyChangedand invokesFixNameItemChangedCommand; the space-bar multi-toggle helper also requests a preview._loading/_oldNames/ lock bookkeeping the polling approach required.TableViewExtras.AddSpaceToggle(parameter rename, lambda simplification).Test plan
🤖 Generated with Claude Code