chore(quality): prefer node:path over path across the codebase - #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second slice of the #107 SonarCloud triage: the S7772 findings,
node:pathpreferred over the barepathspecifier for built-in modules. Mechanical, one import line per file, no behavior change; 16 files touched,pathcovered every occurrence, no other Node built-ins were imported bare anywhere insrc/. The test suite already usednode:patheverywhere, so this bringssrc/in line with that existing convention rather than introducing a new one.Type
Checklist
dev, notmain.npm run typecheckpasses.npm run lint:cipasses.npm run format:checkpasses.npm run test:coveragepasses, coverage at or above the floor invitest.config.ts.npm run build:unpackpasses.Testing
Import-only change, no logic touched. Ran the full gate list: typecheck, lint:ci, format:check, test:coverage (statements 90.52%, branches 87.72%, functions 88.31%, lines 92.15%, all above the configured floor, same suite that already exercises every file changed here), and build:unpack, all green.
Related issues
Refs #107 (leaves the remaining findings, mainly the 66 read-only-props S6759 findings, for a separate slice)