Skip to content

Add grid helper unit tests - #3273

Merged
Crabcyborg merged 2 commits into
masterfrom
add_grid_helper_unit_tests
Aug 24, 2026
Merged

Add grid helper unit tests#3273
Crabcyborg merged 2 commits into
masterfrom
add_grid_helper_unit_tests

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Crabcyborg Crabcyborg added this to the 6.35 milestone Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 36 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f632a37-23ad-4192-a7cd-7a40a9970594

📥 Commits

Reviewing files that changed from the base of the PR and between 4b186e3 and 475d9bc.

📒 Files selected for processing (1)
  • tests/phpunit/fields/test_FrmFieldGridHelper.php.php

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 4b186e3...475d9bc on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Aug 24, 2026 8:51p.m. Review ↗
JavaScript Aug 24, 2026 8:51p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

deepsource-io[bot]
deepsource-io Bot reviewed Aug 24, 2026
View reviewed changes
Comment thread tests/phpunit/fields/test_FrmFieldGridHelper.php.php
* @return FrmFieldGridHelper
*/
private function build_helper_for_classes( $classes ) {
$this->form_id = $this->factory->form->create();

@deepsource-io deepsource-io Bot Aug 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Access to an undefined property WP_UnitTest_Factory::$form


The property you are trying to access is not defined and will cause unexpected behavior when used.

Comment thread tests/phpunit/fields/test_FrmFieldGridHelper.php.php
* row while handling a section field discards the helper that set_field() just created.
*/
public function test_a_section_keeps_its_helper_after_the_row_bookkeeping_runs() {
$this->form_id = $this->factory->form->create();

@deepsource-io deepsource-io Bot Aug 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Access to an undefined property WP_UnitTest_Factory::$form


The property you are trying to access is not defined and will cause unexpected behavior when used.

Comment thread tests/phpunit/fields/test_FrmFieldGridHelper.php.php
* @return string
*/
private function get_grid_layout( $specs ) {
$this->form_id = $this->factory->form->create();

@deepsource-io deepsource-io Bot Aug 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Access to an undefined property WP_UnitTest_Factory::$form


The property you are trying to access is not defined and will cause unexpected behavior when used.

@Crabcyborg
Crabcyborg merged commit 538d304 into master Aug 24, 2026
21 of 22 checks passed
@Crabcyborg
Crabcyborg deleted the add_grid_helper_unit_tests branch August 24, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepsource-io deepsource-io[bot] deepsource-io[bot] left review comments

Assignees

No one assigned

Labels

run analysis run tests

Projects

None yet

Milestone

6.35

Development

Successfully merging this pull request may close these issues.

1 participant

@Crabcyborg