Skip to content

Fixed various LBL crashes. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rip-Rip-Rip wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed various LBL crashes. #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions light_bridge_lights/scripts/vscripts/light_bridge_lights/helper.nut
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,11 @@ if(!("LBL_Dev" in getroottable())) {
function distance(vec1, vec2) {
return (vec1 - vec2).Length()
}

function numOfItemsInTable(table) {
local count = 0
foreach(item in table) count++
return count
}
}
}
5 changes: 3 additions & 2 deletions light_bridge_lights/scripts/vscripts/sv_init.nut
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const LBL_LIGHT_VOLUMETRIC_DENSITY = 0.025

const LBL_LIGHT_SPACING = 24 // distance between lights in units, less spacing means more lights but a higher performance cost
const LBL_LIGHT_MAXCOUNT = 128 // maximum number of lights per bridge to prevent performance issues
const LBL_MAX_NUMBER_OF_LIT_BRIDGES = 4 // max number of bridges that can have lights at once, having too many could cause a crash depending on the length of the bridges (due to the increased number of lights)

const LBL_LIGHT_SPECIFIC_HEALTH = 27852 // used to identify lights created by this script

Expand Down Expand Up @@ -99,7 +100,7 @@ function LBL_bridgeCacheRefresh() {
if(!bridge.IsValid()) {
LBL_lightRemoveAtBridge(bridgeIndex)
LBL_bridgesCacheMarkedForReset = true // wait until next tick to prevent crashes
break
return
}

local lightCountNew = LBL_bridgeGetLightCount(bridge)
Expand All @@ -116,7 +117,7 @@ function LBL_bridgeCacheRefresh() {
}

for(local bridge = null; bridge = Entities.FindByClassname(bridge, "projected_wall_entity");) {
if(LBL_bridgeIsCached(bridge) || !bridge.IsValid()) continue // skip cached bridges or invalid bridges
if(LBL_bridgeIsCached(bridge) || !bridge.IsValid() || LBL_Dev.numOfItemsInTable(LBL_bridgesCached) >= LBL_MAX_NUMBER_OF_LIT_BRIDGES) continue // skip cached bridges or invalid bridges, and prevent too many lit bridges to prevent crashes

// update cache with new bridge

Expand Down