Stamp the release heading for 11.1.0.0 - #152
Merged
Merged
Conversation
The section going out today was still titled "Unreleased". Promoting with it that way leaves the v11.1.0 tag pointing at a changelog whose top section names neither version nor date, and by then it is too late to fix for that tag. Dated 08/27/2026, the day of the rollout, following the convention of the headings above it - those track the commit date in UTC. Checked by running the release workflow's own extraction against it rather than by eye: version 11.1.0.0 resolves from Xrpl.csproj, the tag comes out v11.1.0, and the notes extract to 5586 characters over 20 lines with no stray heading caught in them. Both entries are present - the JsonSerializerOptions change and the out-of-range amounts. Nothing else changes. CHANGES.md is not packed into any NuGet package, so this affects the repository and the tag rather than what gets published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release preparation for today's rollout. One line.
CHANGES.mdstill opened with## Unreleased. Promotingdevintoreleasein that state would leave thev11.1.0tag pointing at a changelog whose top section names neither a version nor a date — and once the tag exists, that is no longer fixable for it.Checked by running the workflow's own logic
Not by eye. The same extraction the release job performs, run against this file:
Xrpl.csproj11.1.0.0v11.1.0##headings caught in them#147and#148Well under the 120000-character truncation threshold, so that branch stays unexercised again.
Worth noting the guard would have caught this anyway:
Resolve version and release notesruns before the build and fails the run when no section matches<PackageVersion>, so an unstamped changelog stops the release while nothing has been published. This is the ordinary way to satisfy it rather than a rescue from it.The date
08/27/2026, the day of the rollout. UTC is already the 27th, and it follows the convention of the headings above — those track the commit date in UTC, as## 11.0.0.0 08/26/2026did.What ships behind this heading
XrplLOVaultfrom #147Xrpl.BinaryCodecXrpl.AddressCodec,Xrpl.Keypairs, bothX402Scope
CHANGES.mdis not packed into any NuGet package —Xrpl.csprojis SDK-style with no<Content>or<None Pack>— so this changes the repository and the tag, not what gets published. No code, no version numbers: those are already ondev.