STAC-24722: move community stackpacks to contrib repo#1
Open
fvlankvelt wants to merge 7 commits into
Open
Conversation
1b69118 to
eb05292
Compare
eb05292 to
7b16f4f
Compare
d604598 to
1f0f63d
Compare
1f0f63d to
88d84ac
Compare
deontaljaard
reviewed
Jul 8, 2026
| name: Update Stackpacks Version in Helm | ||
|
|
||
| # Triggers the helm-charts-internal updatecli workflow after stackpacks have | ||
| # been built and uploaded. Invoked from the CI workflow on master. |
There was a problem hiding this comment.
This invocation is missing atm, is it still intended to be there (added later when manual testing is done)?
| name: package (${{ matrix.stackpack }}) | ||
| needs: [validate] | ||
| if: | | ||
| always() && |
There was a problem hiding this comment.
Wondering if this shouldn't be gated to push for main only? Public fork PRs will hit missing secret failures, and same-repo branches could publish images.
| branches: [main] | ||
| workflow_dispatch: | ||
| inputs: | ||
| build_docker_image: |
| - name: Compute image tag | ||
| id: tag | ||
| run: | | ||
| git_branch="${GITHUB_HEAD_REF:-${GITHUB_REF_NAME}}" |
There was a problem hiding this comment.
Should we do some sanitisation? Branch names with / will produce invalid tags
deontaljaard
reviewed
Jul 8, 2026
| @@ -0,0 +1,300 @@ | |||
| name: Contrib Stackpacks CI | |||
There was a problem hiding this comment.
I think it could also be worthwhile to add a workflow linting workflow, like https://github.com/StackVista/image-pipeline/blob/main/.github/workflows/lint-workflows.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.