Skip to content

STAC-24722: move community stackpacks to contrib repo#1

Open
fvlankvelt wants to merge 7 commits into
mainfrom
STAC-24722-community-stackpacks-in-contrib
Open

STAC-24722: move community stackpacks to contrib repo#1
fvlankvelt wants to merge 7 commits into
mainfrom
STAC-24722-community-stackpacks-in-contrib

Conversation

@fvlankvelt

Copy link
Copy Markdown

No description provided.

@fvlankvelt fvlankvelt force-pushed the STAC-24722-community-stackpacks-in-contrib branch 2 times, most recently from 1b69118 to eb05292 Compare July 3, 2026 10:15
@fvlankvelt fvlankvelt force-pushed the STAC-24722-community-stackpacks-in-contrib branch from eb05292 to 7b16f4f Compare July 3, 2026 11:05
@fvlankvelt fvlankvelt force-pushed the STAC-24722-community-stackpacks-in-contrib branch 4 times, most recently from d604598 to 1f0f63d Compare July 3, 2026 14:11
@fvlankvelt fvlankvelt force-pushed the STAC-24722-community-stackpacks-in-contrib branch from 1f0f63d to 88d84ac Compare July 3, 2026 14:19
name: Update Stackpacks Version in Helm

# Triggers the helm-charts-internal updatecli workflow after stackpacks have
# been built and uploaded. Invoked from the CI workflow on master.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This invocation is missing atm, is it still intended to be there (added later when manual testing is done)?

name: package (${{ matrix.stackpack }})
needs: [validate]
if: |
always() &&

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this shouldn't be gated to push for main only? Public fork PRs will hit missing secret failures, and same-repo branches could publish images.

branches: [main]
workflow_dispatch:
inputs:
build_docker_image:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This input looks unused.

- name: Compute image tag
id: tag
run: |
git_branch="${GITHUB_HEAD_REF:-${GITHUB_REF_NAME}}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do some sanitisation? Branch names with / will produce invalid tags

@@ -0,0 +1,300 @@
name: Contrib Stackpacks CI

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could also be worthwhile to add a workflow linting workflow, like https://github.com/StackVista/image-pipeline/blob/main/.github/workflows/lint-workflows.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants