Add support for gevent#6372
Open
skiedude wants to merge 11 commits into
Open
Conversation
* Bump pip and setuptools and switch from setup.py to pip install * Add gevent to requirements, bumps for compatibility and regenerate requirement files. * Display which components fail unit tests. * Add checks for eventlet code in monkey patch
pull-request-size
Bot
added
the
size/XXL
Contributor
|
looks like you have some failing unit tests |
- Took upstream's CI image bumps (py3.10, mongo 8.2, rabbitmq 4.2) in .circleci/config.yml - Merged Makefile: kept setuptools_scm/python -m build (needed for gevent's setuptools pin), took upstream's $(PYBIN) consistency - fixed-requirements.txt: kept gevent/eventlet/greenlet/gunicorn pins, dropped unused flex, picked up importlib_resources/importlib_metadata - Regenerated all per-component requirements.txt via make requirements - Regenerated lockfiles/st2.lock via pants generate-lockfiles --resolve=st2 - st2client httpclient.py: resolved shlex.quote alias naming - test_service_setup_log_level_filtering.py: kept concurrency.sleep() abstraction, took upstream's SIGTERM/8s timeout flakiness fix
skiedude
commented
Jul 24, 2026
| gevent = None | ||
|
|
||
| CONCURRENCY_LIBRARY = "eventlet" | ||
| CONCURRENCY_LIBRARY = os.environ.get("ST2_CONCURRENCY_LIBRARY", "eventlet") |
Contributor
Author
There was a problem hiding this comment.
@nzlosh @guzzijones right now I have the utility as an envvar in order to swap between eventlet/gevent, with defaulting to eventlent.
Now that all the tests are passing (existing functionality using eventlet), I will change that to gevent to be the default (whole purpose of this PR).
But any feedback or alternate ideas on how to manage this vs what this is doing now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.