Skip to content

Update docker files to follow solar lint rules#63

Open
docbyte86 wants to merge 6 commits into
StackStorm:masterfrom
docbyte86:bugfix/solarlint
Open

Update docker files to follow solar lint rules#63
docbyte86 wants to merge 6 commits into
StackStorm:masterfrom
docbyte86:bugfix/solarlint

Conversation

@docbyte86
Copy link
Copy Markdown

"WORKDIR" instruction should be used instead of "cd" commands (docker:S6597)
In Dockerfile, instructions RUN, CMD, and ENTRYPOINT can contain long shell scripts chaining multiple commands, including the cd command for changing directories. Using WORKDIR instruction instead reduces the complexity of the above instructions and makes them easier to read, understand, troubleshoot, and maintain.

Cache should be cleaned after package installation (docker:S6587)
Docker images should only contain necessary data. The package index is optional for the correct working of the installed software. Storing an index also increases the size of the Docker image. It should be reduced to speed up deployments and reduce storage and bandwidth.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 10, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ docbyte86
❌ Tobias Ramm


Tobias Ramm seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@docbyte86
Copy link
Copy Markdown
Author

@cognifloyd , kindly request an approval for this change or leave a comment. thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants