Skip to content

fix(docs-next): External url paths in sidebar are truncated #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dancormier merged 6 commits into from
Apr 24, 2026
+12 −6
Merged

fix(docs-next): External url paths in sidebar are truncated #2245

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b191ffb
fix external url paths in sidebar
abovedave Apr 20, 2026
ccca3cd
fix lint
abovedave Apr 23, 2026
ae42875
break out into a variable
abovedave Apr 23, 2026
3cb481c
const afer each
abovedave Apr 23, 2026
95877cf
fix(docs-next): use item.externalUrl for nested nav rel attribute
dancormier Apr 24, 2026
c850fa7
fix(docs-next): keep href on same line as <a> so eslint-disable applies
dancormier Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions packages/stacks-docs-next/src/components/Navigation.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,14 @@
<div transition:slide={{ duration: 200 }}>
<ul class="s-navigation s-navigation__vertical pl24">
{#each category.items as subsection (subsection.slug)}
{@const subsectionHref = subsection.externalUrl ? subsection.externalUrl : resolve(`/${category.slug}/${subsection.slug}/${subsection?.items ? subsection?.items[0]?.slug : ''}`)}

<li>
<a
<!-- eslint-disable-next-line svelte/no-navigation-without-resolve -->
<a href={subsectionHref}
class="s-navigation--item jc-space-between mb1"
class:is-selected={sectionSlug === subsection.slug || subsectionSlug === subsection.slug}
href={resolve(subsection.externalUrl || `/${category.slug}/${subsection.slug}/${subsection?.items ? subsection?.items[0]?.slug : ''}`)}
rel={subsection.externalUrl ? "external" : undefined}
data-sveltekit-reload={subsection.private ? true : undefined}
>
<span>{subsection.title}</span>
Expand All @@ -82,19 +85,22 @@
{#if subsection.externalUrl}
<Icon src={IconArrowUpRightBox} />
{/if}
</span>
</span>
{/if}
</a>

{#if subsection?.items && sectionSlug === subsection.slug}
<div transition:slide={{ duration: 200 }}>
<ul class="s-navigation s-navigation__vertical ml24">
{#each subsection?.items as item (item.slug)}
{@const itemHref = item.externalUrl ? item.externalUrl : resolve(`/${category.slug}/${subsection.slug}/${item.slug}/`)}

<li>
<a
<!-- eslint-disable-next-line svelte/no-navigation-without-resolve -->
<a href={itemHref}
class="s-navigation--item jc-space-between mb1"
class:is-selected={subsectionSlug === item.slug}
href={resolve(item.externalUrl || `/${category.slug}/${subsection.slug}/${item.slug}/`)}
rel={item.externalUrl ? "external" : undefined}
data-sveltekit-reload={item.private ? true : undefined}
>
<span>{item.title}</span>
Expand Down Expand Up @@ -132,4 +138,4 @@
background: var(--black-600) !important;
color: var(--white) !important;
}
</style>
</style>
Loading