CI: stop dpkg starting redis-server (Windows/WSL install hang on 8.10) - #3145
Merged
Conversation
We hand-start every server instance the tests need, so drop a policy-rc.d that tells invoke-rc.d/deb-systemd-invoke not to start services at all. The packaged redis-server unit would otherwise race our own primary for 127.0.0.1:6379 on any run where WSL came up with systemd. That also sidesteps an install hang we saw with the 8.10.0 package: its redis.conf lost "supervised auto", so redis never sd_notify()s, the Type=notify unit never leaves "activating", and the postinst's "systemctl start" blocks (indefinitely, since redis then can't save its RDB on SIGTERM and the unit disables the stop timeout). That is an upstream packaging slip which they are already fixing, so this isn't a permanent change in behaviour from 8.10 - but not starting the service is the right thing for this job regardless. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mgravell
force-pushed
the
marc/ci-redis-8.10-install-hang
branch
from
July 30, 2026 08:55
64be40d to
c381cd4
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows job's "Install Redis" step began stalling indefinitely once server 8.10.0 hit packages.redis.io. Reproduced locally in a systemd-running jammy container: 8.8.1 installs in ~4s, 8.10.0 never returns.
The 8.10.0 redis-server deb ships the upstream redis.conf rather than the Debian-patched one (control scripts and the systemd unit are unchanged, so this doesn't show up in a package diff). It drops "supervised auto" and changes "dir /var/lib/redis" to "dir ./", which deadlocks the postinst: redis never sd_notify()s, so the Type=notify unit never leaves "activating" and "systemctl start" blocks; at TimeoutStartSec systemd SIGTERMs it, the final RDB save fails against the unit's read-only root so redis refuses to exit; and the unit's TimeoutStopSec=0 means systemd never SIGKILLs it.
We hand-start every server instance we need, so drop a policy-rc.d that tells invoke-rc.d/deb-systemd-invoke not to start services at all. This also stops the packaged unit racing us for 127.0.0.1:6379, which it would win or lose non-deterministically on runs where WSL came up with systemd.
Checklist