refactor: retheme the playground chrome from ShellPalette to flow_ui tokens - #26
Conversation
|
@cursoragent review |
|
Reviewed PR #26 (playground chrome onto The retheme looks solid: Posted on the PR:
No functional issues. Not blocking. |
ReviewThis is a clean, well-scoped retheme. Deleting The dark segmented-pill branch is the one place a single token cannot do the job, and the comment is accurate: an opaque CI is green ( Nits, not blockers
style: shellText(
size: 12.5,
weight: FontWeight.w500,
color: active ? colors.onSurface : colors.onSurfaceMuted,
No functional problems. Happy to see this land. |
| size: 12.5, | ||
| weight: FontWeight.w500, | ||
| color: active ? shell.text : shell.segmentRest, | ||
| color: active ? colors.onSurface : colors.onSurfaceMuted, |
There was a problem hiding this comment.
Nit: nav rows at rest use onSurfaceVariant (the “labels at rest” rung). These unselected segment labels use onSurfaceMuted (placeholders / carets), which matches the old segmentRest grey but is a step quieter than the rest of the chrome’s interactive labels. Intentional to keep the prototype’s split, or should this follow the nav rows?


Summary
The playground chrome — top bar, sidebar, stage, and code panel — previously painted itself from a private
ShellPalettecopied out of the Claude Design prototype. It now readscontext.flowColorslike the component demos do, so the workbench exercises the package's own token set and flips theme together with the exhibit.ShellPaletteandshellAccent; keep the smallshellTextFigtree helper in a newshell_text.dart(the chrome keeps its bespoke font sizes — only colors changed).surfaceBright; the canvas and phone screen onsurface; hairlines areoutlineVariant, withoutlineon the floating variant pill.onSurface/onSurfaceVariant/onSurfaceMutedramp; the accent (active nav icon, copy confirmation) isprimary.surfaceContainer, nav hoversurfaceContainerLow, active nav rowsurfaceContainer, preserving the design's hover-below-selected ordering.surfaceBrightin light butsurfaceContainerHighestin dark — an opaquesurfaceBrightpill would sink below the track's ink wash in dark, while the strongest wash composites to the prototype's raised grey.Testing
flutter analyzeclean.