Isolate query failures in publish pipeline (#45)#103
Open
BWilliams1004 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45. Catches exceptions in
execute_and_upload_pgso a single failing query gets logged via Prefect's run logger instead of crashing the whole pipeline run. Since the page-building step already discovers files via an S3 glob rather than by inspecting task results, a failed query is simply skipped rather than blocking the archive/docs build for everything else.The parquet file uploads fine, but the CSV write throws. You would end up with a partially published file even though the task reports a total failure.
Note on testing: Verified locally that this catches and logs exceptions correctly, but couldn’t run a full end-to-end test since I don’t yet have a working Prefect API connection (separate issue, following up on that). Would appreciate a check from someone with that access.