#4288: Fix incompatibility with Compact Machines#4290
Open
AlexandreArcil wants to merge 1 commit intoSpongePowered:api-12from
Open
#4288: Fix incompatibility with Compact Machines#4290AlexandreArcil wants to merge 1 commit intoSpongePowered:api-12from
AlexandreArcil wants to merge 1 commit intoSpongePowered:api-12from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4288: Incompatibility in commands between CompactMachines and SpongeNeo
Compact Machines is reloading the packs with an immutable list but Sponge Common tried to add other packs to the list, which threw an UnsupportedOperationException.
https://github.com/CompactMods/CompactMachines/blob/21.1/main/neoforge-main/src/main/java/dev/compactmods/machines/command/EnableBasicTemplatesSubcommand.java#L36
The fix consists of adding the Compact Machines packs to the Sponge packs list since it's an ArrayList, and then replacing the initial list with the Sponge packs list.