Equalize dock zone sizes on startup#265
Open
xiao-1011 wants to merge 7 commits intoSpikeInterface:mainfrom
Open
Equalize dock zone sizes on startup#265xiao-1011 wants to merge 7 commits intoSpikeInterface:mainfrom
xiao-1011 wants to merge 7 commits intoSpikeInterface:mainfrom
Conversation
`get_visible_unit_ids()` returned a direct reference to the internal `_visible_unit_ids` list. Callers that snapshot the list before and after `set_unit_visibility()` to detect changes were comparing the same mutated object, so the comparison always found no difference and never triggered `notify_unit_visibility_changed()`. Return a copy instead so before/after comparisons work correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…copy Fix unit visibility change not propagating to other views
Dock widgets created by splitDockWidget() have uneven default sizes. Add a showEvent hook that calls resizeDocks() with equal weights after the window is visible, so all zones start proportionally sized. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace QTimer.singleShot(100ms) hack with QApplication.processEvents() to flush pending layout events synchronously before calling resizeDocks. Deterministic and avoids arbitrary delay. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Feature/equalize dock sizes
| def get_visible_unit_ids(self): | ||
| """Get list of visible unit_ids""" | ||
| return self._visible_unit_ids | ||
| return list(self._visible_unit_ids) |
Contributor
Author
There was a problem hiding this comment.
this was to fix #264 unit visibility propagation issue. I should have restored this line since these 2 issues are independent :)
Member
|
thank you for this. |
Member
|
Hi @xiao-1011 , I'm not sure this is doing what it's meant to do. Here my is initial window on main: 
and on this branch: 
Do you have local runs that equalise the docks? |
Replace synchronous processEvents() + resizeDocks() with a deferred QTimer.singleShot(0) call. On macOS, the Cocoa window system performs a layout pass after Qt's showEvent, overwriting sizes set synchronously. The deferred call ensures resizeDocks runs after the native layout completes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fix/macos dock equalization
Contributor
Author
|
Hi @chrishalcrow , thanks for checking! It seems to be a macos specific issue. Original PR works on Windows 11 and Ubuntu 24.04. The branch should now work on macos (at least on my macbook) hopefully. Can you give it a try? |
Member
|
Wow beautiful!! 
(not the unit, but the GUI!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
splitDockWidget()have uneven default sizes, causing zones that span multiple slots to be disproportionately larger than their neighborsshowEventhook inQtMainWindowthat callsresizeDocks()with equal weights for all visible docks in both horizontal and vertical orientationsQApplication.processEvents()to flush pending layout events before resizing, ensuring the window geometry is finalized — no arbitrary timer delay needed_splitters_equalizedguardTest plan
default,legacy,unit_focus)🤖 Generated with Claude Code