fix: avoid t8s HelmRelease name colliding with run_plugin's cluster_id - #1261
Merged
mbuechse merged 1 commit intoJul 30, 2026
Merged
Conversation
cwrau
force-pushed
the
fix/t8s-hr-name-config-collision
branch
from
July 30, 2026 17:48
6c883ce to
e5e17c8
Compare
run_plugin.py sets config['name'] to the cluster_id for every plugin kind, so PluginT8s's use of the same key for the VAP/RBAC-mandated HelmRelease name never fell back to its intended value. Renamed to 'hrName', now set explicitly in clusters.yaml.j2 for each teuto entry instead of defaulted in code. Signed-off-by: Chris Werner Rau <cwrau@cwrau.info>
cwrau
force-pushed
the
fix/t8s-hr-name-config-collision
branch
from
July 30, 2026 18:08
e5e17c8 to
48fe84f
Compare
mbuechse
approved these changes
Jul 30, 2026
mbuechse
left a comment
mbuechse
left a comment
Contributor
There was a problem hiding this comment.
Looking great. Thanks a ton for the quick action!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_plugin.pysetsconfig['name']to the cluster_id (e.g.teuto-1.36) for every plugin kind, for use by other plugins.PluginT8s(merged in feat: add t8s kaas offering #1244) reused that samenamekey for the VAP/RBAC-mandated HelmRelease name, so its"scs-kaas-certification"default never took effect — the HelmRelease was created asteuto-1.36/teuto-1.35instead, which the ValidatingAdmissionPolicy on the management cluster rejects, breaking CI.hrNameto avoid the collision.teuto-1.35/teuto-1.36entries inclusters.yaml.j2don't set it, so they correctly fall back toscs-kaas-certification.Test plan
test_hr_name_ignores_run_plugin_name, simulatingrun_plugin.py'ssetdefault('name', cluster_id)behavior, to prevent regression.python -m pytest Tests/kaas/plugin— 29/29 passed.flake8 --config=.flake8— clean except pre-existing unrelated warnings.