SONARJAVA-6604 Implement S9016: Mock objects should not be created inline within "thenReturn()"

[NoemieBenard]

---

Summary by Gitar

• New Rule Implementation:
  • Added MockitoInlineMockInThenReturnCheck to detect mock creation inside thenReturn() calls.
  • Created rule documentation and metadata files for S9016.
• Testing & Infrastructure:
  • Implemented unit tests for the new rule including semantic analysis verification.
  • Integrated rule into the test suite and updated autoscan/ruling test expectations.

_{This will update automatically on new commits.}

[hashicorp-vault-sonar-prod]

SONARJAVA-6604

[github-actions]

Ruling Diff Summary

Detected changes in 1 rule files: 0 issues removed, 7 issues added.

S9016 (java) on sonar-server - 0 issues removed, 7 issues added - new ruling file

Added src/test/java/org/sonar/server/app/TomcatContextsTest.java (line 60)

(source file not found at this revision: src/test/java/org/sonar/server/app/TomcatContextsTest.java)

Added src/test/java/org/sonar/server/authentication/OAuth2CallbackFilterTest.java (line 75)

(source file not found at this revision: src/test/java/org/sonar/server/authentication/OAuth2CallbackFilterTest.java)

Added src/test/java/org/sonar/server/issue/ws/ComponentTagsActionTest.java (line 93)

(source file not found at this revision: src/test/java/org/sonar/server/issue/ws/ComponentTagsActionTest.java)

Added src/test/java/org/sonar/server/issue/ws/ComponentTagsActionTest.java (line 117)

(source file not found at this revision: src/test/java/org/sonar/server/issue/ws/ComponentTagsActionTest.java)

Added src/test/java/org/sonar/server/plugins/StaticResourcesServletTest.java (line 145)

(source file not found at this revision: src/test/java/org/sonar/server/plugins/StaticResourcesServletTest.java)

Added src/test/java/org/sonar/server/rule/RegisterRulesTest.java (line 486)

(source file not found at this revision: src/test/java/org/sonar/server/rule/RegisterRulesTest.java)

Added src/test/java/org/sonar/server/rule/WebServerRuleFinderImplTest.java (line 41)

(source file not found at this revision: src/test/java/org/sonar/server/rule/WebServerRuleFinderImplTest.java)

[gitar-bot]

Code Review ✅ Approved

Implements S9016 to prevent inline mock creation within thenReturn() calls, including full test coverage and rule metadata. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
97.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube