Skip to content

SONARJAVA-6397 Add Mall spring project to ruling test#5630

Open
leonardo-pilastri-sonarsource wants to merge 3 commits into
masterfrom
lp/add-ruling-mall
Open

SONARJAVA-6397 Add Mall spring project to ruling test#5630
leonardo-pilastri-sonarsource wants to merge 3 commits into
masterfrom
lp/add-ruling-mall

Conversation

@leonardo-pilastri-sonarsource
Copy link
Copy Markdown
Contributor

@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource commented May 26, 2026


Summary by Gitar

  • Test infrastructure:
    • Added mall spring project to the integration ruling tests.
    • Updated its/sources to track lp/add-spring-ruling branch.
    • Added extensive rule violation baselines (.json files) for various SonarJava rules in its/ruling/src/test/resources/mall/.

This will update automatically on new commits.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Add Mall spring project to ruling test SONARJAVA-6397 Add Mall spring project to ruling test May 26, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown
Contributor

hashicorp-vault-sonar-prod Bot commented May 26, 2026

SONARJAVA-6397

Comment thread .gitmodules
[submodule "its/sources"]
path = its/sources
url = https://github.com/SonarSource/ruling_java.git
branch = lp/add-spring-ruling
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Quality: Submodule .gitmodules points to feature branch instead of master

The .gitmodules file now specifies branch = lp/add-spring-ruling, which is a feature branch in the ruling_java repository. If this branch is deleted or not merged into the default branch of that repo before this PR lands on master, the submodule tracking will break for anyone doing git submodule update --remote. Typically submodules should track a stable branch (e.g., master or main). Either merge the feature branch in ruling_java first and remove the branch line (so it defaults to the remote HEAD), or update it to point to the stable branch after the ruling_java PR is merged.

Remove the branch line so the submodule tracks the default branch of the remote (after merging lp/add-spring-ruling into the default branch of ruling_java):

[submodule "its/sources"]
	path = its/sources
	url = https://github.com/SonarSource/ruling_java.git
  • Apply fix

Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 28, 2026

Code Review ⚠️ Changes requested 0 resolved / 1 findings

Integrates the Mall spring project into the ruling test suite, but the .gitmodules file incorrectly points to a feature branch instead of master, which will cause CI failures.

⚠️ Quality: Submodule .gitmodules points to feature branch instead of master

📄 .gitmodules:4

The .gitmodules file now specifies branch = lp/add-spring-ruling, which is a feature branch in the ruling_java repository. If this branch is deleted or not merged into the default branch of that repo before this PR lands on master, the submodule tracking will break for anyone doing git submodule update --remote. Typically submodules should track a stable branch (e.g., master or main). Either merge the feature branch in ruling_java first and remove the branch line (so it defaults to the remote HEAD), or update it to point to the stable branch after the ruling_java PR is merged.

Remove the branch line so the submodule tracks the default branch of the remote (after merging lp/add-spring-ruling into the default branch of ruling_java)
[submodule "its/sources"]
	path = its/sources
	url = https://github.com/SonarSource/ruling_java.git
🤖 Prompt for agents
Code Review: Integrates the Mall spring project into the ruling test suite, but the .gitmodules file incorrectly points to a feature branch instead of master, which will cause CI failures.

1. ⚠️ Quality: Submodule .gitmodules points to feature branch instead of master
   Files: .gitmodules:4

   The `.gitmodules` file now specifies `branch = lp/add-spring-ruling`, which is a feature branch in the `ruling_java` repository. If this branch is deleted or not merged into the default branch of that repo before this PR lands on `master`, the submodule tracking will break for anyone doing `git submodule update --remote`. Typically submodules should track a stable branch (e.g., `master` or `main`). Either merge the feature branch in `ruling_java` first and remove the `branch` line (so it defaults to the remote HEAD), or update it to point to the stable branch after the ruling_java PR is merged.

   Fix (Remove the branch line so the submodule tracks the default branch of the remote (after merging lp/add-spring-ruling into the default branch of ruling_java)):
   [submodule "its/sources"]
   	path = its/sources
   	url = https://github.com/SonarSource/ruling_java.git

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.
Unblock → Override a blocking verdict and allow merging.

Comment with these commands to change:

Auto-apply Compact Unblock
gitar auto-apply:on         
gitar display:verbose         
gitar unblock         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant