Skip to content

ECHOES-1427 Adjust layout aside padding#731

Open
marciopmoreira6 wants to merge 1 commit into
mainfrom
fix/ECHOES-1427-aside-padding
Open

ECHOES-1427 Adjust layout aside padding#731
marciopmoreira6 wants to merge 1 commit into
mainfrom
fix/ECHOES-1427-aside-padding

Conversation

@marciopmoreira6

Copy link
Copy Markdown
Contributor

Summary

  • Adjust Layout.AsideLeft padding per aside size using Echoes spacing tokens
  • Keep aside width and padding driven by the size style map
  • Update LayoutSlots tests to cover width and padding tokens via local render helpers

Jira

https://sonarsource.atlassian.net/browse/ECHOES-1427?search_id=752e8517-21ac-4edc-9a76-fa70d7950116

Verification

  • yarn prettier --write src/components/layout/tests/LayoutSlots-test.tsx
  • yarn jest src/components/layout/tests/LayoutSlots-test.tsx
  • yarn ts-check

@netlify

netlify Bot commented Jul 13, 2026

Copy link
Copy Markdown

Deploy Preview for echoes-react ready!

Name Link
🔨 Latest commit 0c5254a
🔍 Latest deploy log https://app.netlify.com/projects/echoes-react/deploys/6a5501b6f1af220008aab723
😎 Deploy Preview https://deploy-preview-731--echoes-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jul 13, 2026

Copy link
Copy Markdown

ECHOES-1427

@gitar-bot

gitar-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Updates Layout.AsideLeft padding using Echoes spacing tokens and enhances test coverage for layout slots. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown

@jeremy-davis-sonarsource jeremy-davis-sonarsource left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants