ECHOES-1071 Add missing max-height on FilterDropdown#728
Open
gregaubert wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for echoes-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
gregaubert
force-pushed
the
greg/filterpattern-story-improvements
branch
from
a8db9e9 to
23f27bc
Compare
gregaubert
force-pushed
the
greg/filterpattern-story-improvements
branch
from
23f27bc to
0987e6d
Compare
Code Review ✅ ApprovedAdds a 600px max-height to the FilterDropdown and reorganizes Storybook categories to better align with production patterns. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
jeremy-davis-sonarsource
approved these changes
Jul 13, 2026
jeremy-davis-sonarsource
left a comment
jeremy-davis-sonarsource
left a comment
Contributor
There was a problem hiding this comment.
Really nice clean up of the stories!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of
Summary by Gitar
max-heighttoFilterDropdownstyling.IconFiltertoFilterDropdownTrigger.filter-dropdown-sizes-max-height-defaulttoken set to600px.Echoes ComponentsandEchoes Patternscategories.FilterToolbarandfilter-dropdown-helpersfor advanced filtering scenarios.Toolbarstories to use slot-based controls for better pattern demonstration.This will update automatically on new commits.