Skip to content

BUILD-11295 test gh-action_cache@feat/.../BUILD-11295-metricsFeatureFlag#267

Draft
julien-carsique-sonarsource wants to merge 2 commits into
masterfrom
test/jcarsique/BUILD-11295-cacheMetrics
Draft

BUILD-11295 test gh-action_cache@feat/.../BUILD-11295-metricsFeatureFlag#267
julien-carsique-sonarsource wants to merge 2 commits into
masterfrom
test/jcarsique/BUILD-11295-cacheMetrics

Conversation

@julien-carsique-sonarsource
Copy link
Copy Markdown
Contributor

@julien-carsique-sonarsource julien-carsique-sonarsource commented May 21, 2026

Purpose

TEST ONLY — DO NOT MERGE. Resurrection of #262 (closed), retargeted to the BUILD-11295 branch of gh-action_cache so we can validate the new CI-metrics gate end-to-end through sonar-dummy CI on sonar-dev runners.

Changes

8 sub-action action.yml files updated:

SonarSource/gh-action_cache@bdecdb71... # v1.5.0
  → SonarSource/gh-action_cache@feat/jcarsique/BUILD-11295-metricsFeatureFlag # TEST ONLY — BUILD-11295

Affected: cache, build-poetry, build-yarn, code-signing, config-gradle, config-maven, config-npm, config-pip.

Validation chain

Links


Summary by Gitar

  • CI Configuration:
    • Updated gh-action_cache reference across eight sub-actions to use the feat/jcarsique/BUILD-11417-extract-symlink-keeper branch.

This will update automatically on new commits.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented May 21, 2026

BUILD-11295
BUILD-11295

Comment thread cache/action.yml Outdated
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 25, 2026

Code Review ⚠️ Changes requested 0 resolved / 1 findings

Updates 8 sub-action files to pin gh-action_cache to a mutable @master branch reference instead of a locked commit SHA, which risks breaking CI if the upstream branch changes. This is marked as test-only but the mutable pin should be replaced with a fixed commit hash before merge.

⚠️ Security: Pinned SHA replaced with mutable @master branch ref

📄 cache/action.yml:39 📄 build-poetry/action.yml:114

All 8 action files replace a pinned commit SHA (@bdecdb71…) with a mutable branch reference (@master). Mutable refs are vulnerable to supply-chain attacks — if the upstream branch is force-pushed or compromised, CI pipelines silently pick up arbitrary code.

The PR description and title say this targets feat/jcarsique/BUILD-11295-metricsFeatureFlag, but the actual diff pins to @master, which is a discrepancy.

Since this is a test-only draft PR labeled DO NOT MERGE, the risk is contained — but ensure the mutable ref is never merged to master. Before merging any follow-up PR, restore SHA-pinned references (pointing to the new release commit of gh-action_cache).

🤖 Prompt for agents
Code Review: Updates 8 sub-action files to pin gh-action_cache to a mutable `@master` branch reference instead of a locked commit SHA, which risks breaking CI if the upstream branch changes. This is marked as test-only but the mutable pin should be replaced with a fixed commit hash before merge.

1. ⚠️ Security: Pinned SHA replaced with mutable `@master` branch ref
   Files: cache/action.yml:39, build-poetry/action.yml:114

   All 8 action files replace a pinned commit SHA (`@bdecdb71…`) with a mutable branch reference (`@master`). Mutable refs are vulnerable to supply-chain attacks — if the upstream branch is force-pushed or compromised, CI pipelines silently pick up arbitrary code.
   
   The PR description and title say this targets `feat/jcarsique/BUILD-11295-metricsFeatureFlag`, but the actual diff pins to `@master`, which is a discrepancy.
   
   Since this is a test-only draft PR labeled DO NOT MERGE, the risk is contained — but ensure the mutable ref is never merged to `master`. Before merging any follow-up PR, restore SHA-pinned references (pointing to the new release commit of `gh-action_cache`).

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.
Unblock → Override a blocking verdict and allow merging.

Comment with these commands to change:

Auto-apply Compact Unblock
gitar auto-apply:on         
gitar display:verbose         
gitar unblock         

Was this helpful? React with 👍 / 👎 | Gitar

DO NOT MERGE — bump back to a tagged version before merging.
Switches the 8 dogfood pins from gh-action_cache@master to the
BUILD-11417 feature branch so this PR exercises the symlink-keeper
extraction end-to-end alongside sonar-dummy#592.

TEST ONLY — do not merge.
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant