fix(terraform): isolate runtime-owned production drift - #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / evidence
Refreshing production plans remained unsafe after the certificate recovery because provider normalization and CI/CD-owned Cloud Run fields appeared as infrastructure updates. A full apply would have created Cloud Run revisions and rewritten an already-correct HTTPS proxy representation while also bundling unrelated Monitoring work.
Observed drift included:
sslCertificatesretained by the Compute APIScope / design
roles/monitoring.editorgrant from the GitHub deployer desired state.Impact and risks
This PR changes ownership/lifecycle boundaries only. It does not deploy Cloud Run, alter revisions/traffic/env, change certificates or DNS, update Cloud SQL/secrets, or apply Monitoring policies. Production is multi-node; no runtime node is touched.
Validation
terraform fmtterraform validate0 destroy, no replacement, no Cloud Run/Cloud SQL/Secret/HTTPS proxy/IAM changesDeployment recommendation