deploy gh-pages from staging#837
Merged
Merged
Conversation
…istry@3.1.2-2) (latest: rdflib@2.4.0)
NoelDeMartin
approved these changes
Jul 18, 2026
NoelDeMartin
left a comment
NoelDeMartin
left a comment
Member
There was a problem hiding this comment.
Only with this modification, the url for the storybook would be https://solidos.github.io/solid-ui/examples/storybook/ right? That is fine, though maybe it's a good time to rethink the url to something like https://solidos.github.io/solid-ui/storybook/ directly (or maybe even https://solidos.github.io/solid-ui/). At this point, I'm not sure we even want to keep the html examples because I'm not sure they are maintaned... Even if they are, we can have both the storybook in the root and the examples in /examples.
Just a suggestion, though. We can move forward with this for now.
Contributor
Author
|
This could be part of the documentation step review.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.