Repository navigation
Fix/source resize - #814
Merged
Merged
Conversation
Prompt: Source pane footer disappears on resize investigate and fix Co-authored-by: Claude Opus 5.5 <claude-5.5-opus@openai.com>
SharonStrats
requested review from
timea-solid
and
a balanced review from Copilot
November 10, 2026 07:37
…@5.0.2-9 pane-registry@5.0.2-3 folder-pane@4.0.1-2 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Photo uploads can silently overwrite existing files because collision checks only consider linked photos and uploads use an unconditional PUT.
No open issues 🎉
What changed in this PR
This PR addresses source-pane resize behavior by preserving active explorer views, alongside broader navigation, profile-heading, and pane improvements.
Changes:
- Preserves selected explorer content during resizing and centralizes navigation, history, and page-header behavior.
- Adds local profile-heading editing and resource dialogs, while replacing local explorer components with shared
solid-uicomponents. - Updates pane rendering, accessibility, error handling, dependencies, and regression tests.
| File | Description |
|---|---|
| vite.config.mts | Excludes build output from watch mode. |
| test/unit/slideshowPane.test.ts | Tests slideshow eligibility. |
| test/unit/rdfSerializationPanes.test.ts | Tests serialization accessibility labels. |
| test/unit/podUtils.test.ts | Tests profile-declared storage discovery. |
| test/unit/paneLayout.test.ts | Tests pane spacing rules. |
| test/unit/navigation/storagePane.test.ts | Tests explicit storage rendering options. |
| test/unit/navigation/state.test.ts | Tests navigation history state. |
| test/unit/navigation/options.test.ts | Tests navigation option compatibility. |
| test/unit/navigation/navbarVisibility.test.ts | Tests asynchronous visibility races. |
| test/unit/navigation/events.test.ts | Tests navigation notifications. |
| test/unit/mainPage/profileHeadingImage.test.ts | Tests heading image recovery. |
| test/unit/mainPage/profileHeadingEditor.test.ts | Tests local heading editing. |
| test/unit/mainPage/profileHeadingData.test.ts | Tests profile data presentation. |
| test/unit/mainPage/header.test.ts | Tests account-menu navigation. |
| test/unit/internalPane.test.ts | Tests bookkeeping and deletion behavior. |
| test/unit/imagePane.test.ts | Tests image content-type detection. |
| test/unit/dataContentPane.test.ts | Tests semantic rendering and link behavior. |
| test/unit/creationPromises.test.ts | Tests pane creation promise contracts. |
| test/unit/components/resourceActionDialog.test.ts | Tests dialog cancellation and focus. |
| test/unit/components/navbar.test.ts | Tests navbar-owned styling. |
| src/utils/webIdUtils.ts | Adds own-profile detection. |
| src/utils/viewerUtils.ts | Centralizes viewer resolution and relationships. |
| src/utils/podUtils.ts | Accepts profile-declared storage roots. |
| src/utils/paneUtils.ts | Preserves storage shells and supports registry injection. |
| src/types.ts | Adds shared viewer and layout types. |
| src/social/socialSections.ts | Makes the friends list a drop surface. |
| src/social/socialPane.ts | Removes its separate profile header. |
| src/slideshow/slideshowPane.js | Filters images and isolates slideshow instances. |
| src/schedule/schedulePane.ts | Improves creation failure handling. |
| src/registerPanes.js | Prioritizes slideshows over folder views. |
| src/RDFXMLPane.ts | Labels generated RDF/XML accessibly. |
| src/pad/padPane.css | Adds a small top inset. |
| src/outline/userInput.js | Adapts editing to div-based property rows. |
| src/outline/queryByExample.js | Supports div-based predicate traversal. |
| src/outline/outlineDomHelpers.ts | Extracts outline cell and icon construction. |
| src/outline/manager.css | Sizes shared explorer providers and panes. |
| src/outline/fileExplorerHelpers.ts | Delegates pane menus to shared utilities. |
| src/navigation/state.ts | Centralizes navigation history state. |
| src/navigation/podContext.ts | Caches pod ownership and storage lookups. |
| src/navigation/options.ts | Defines navigation and folder-view options. |
| src/navigation/navbarVisibility.ts | Guards visibility against stale lookups. |
| src/navigation/events.ts | Adds navigation notifications. |
| src/navigation/controller.ts | Centralizes view selection and follow-up updates. |
| src/navigation/chrome.ts | Defines heading, navbar, and explorer-header rules. |
| src/navigation/browserEvents.ts | Handles browser-driven navigation. |
| src/n3Pane.ts | Labels generated N3 accessibly. |
| src/mainPage/profileHeading.css | Adds heading mount spacing. |
| src/mainPage/navigation.ts | Shares controllers per outliner. |
| src/mainPage/navbar.ts | Rebuilds navigation for the current pod. |
| src/mainPage/index.ts | Integrates navigation and resize preservation. |
| src/mainPage/header.ts | Routes account actions through the controller. |
| src/internal/internalPane.ts | Adds resource dialogs and safer bookkeeping. |
| src/internal/internalPane.css | Adjusts controls and pane spacing. |
| src/index.ts | Exports navigation and heading integration hooks. |
| src/imagePane.ts | Detects image responses and handles load failures. |
| src/icons/signUp.svg | Removes a local icon asset. |
| src/icons/signOut.svg | Removes a local icon asset. |
| src/icons/downArrow.svg | Removes a local icon asset. |
| src/icons/comment.svg | Removes a local icon asset. |
| src/icons/clock.svg | Removes a local icon asset. |
| src/humanReadablePane.css | Revises preview sizing and scrolling. |
| src/dokieli/dokieliPane.js | Propagates document creation failures. |
| src/defaultPane.css | Styles div-based property rows and gutters. |
| src/components/resource-actions-menu/ResourceActionsMenu.ts | Removes the local resource menu. |
| src/components/resource-actions-menu/ResourceActionsMenu.styles.css | Removes local resource-menu styles. |
| src/components/resource-actions-menu/DeleteResourceDialog.ts | Removes the previous deletion dialog. |
| src/components/resource-action-dialog/ResourceActionDialog.ts | Adds confirmation and informational dialogs. |
| src/components/resource-action-dialog/ResourceActionDialog.styles.css | Styles resource dialogs and focus indicators. |
| src/components/profile-heading/profileHeadingData.ts | Presents local RDF profile data. |
| src/components/profile-heading/index.ts | Exports the profile-heading component. |
| src/components/profile-heading/friendActions.ts | Adds friendship lookup and mutation helpers. |
| src/components/profile-heading/editor/utils/errorDisplay.ts | Formats displayed errors. |
| src/components/profile-heading/editor/ui/spinner.ts | Adds saving feedback. |
| src/components/profile-heading/editor/ui/dialog.responsive.css | Adds responsive editor-dialog styling. |
| src/components/profile-heading/editor/ui/dialog.css | Adds editor-dialog layout and states. |
| src/components/profile-heading/editor/textUtils.ts | Adds text conversion and sanitization helpers. |
| src/components/profile-heading/editor/texts/qrCodeTexts.ts | Defines contact-action text. |
| src/components/profile-heading/editor/texts/profileTexts.ts | Defines profile section labels. |
| src/components/profile-heading/editor/texts/messageTexts.ts | Defines feedback and error messages. |
| src/components/profile-heading/editor/texts/dialogTexts.ts | Defines dialog titles and actions. |
| src/components/profile-heading/editor/texts/buttonTexts.ts | Defines relationship-action labels. |
| src/components/profile-heading/editor/texts.ts | Re-exports editor text constants. |
| src/components/profile-heading/editor/sections/shared/types.ts | Defines shared mutation types. |
| src/components/profile-heading/editor/sections/shared/sanitizeUtils.ts | Sanitizes contact input values. |
| src/components/profile-heading/editor/sections/shared/rowState.ts | Tracks editable-row mutations. |
| src/components/profile-heading/editor/sections/shared/idNodeFactory.ts | Generates RDF entry identifiers. |
| src/components/profile-heading/editor/sections/shared/contactTypeUtils.ts | Normalizes contact type labels. |
| src/components/profile-heading/editor/sections/heading/types.ts | Defines heading presentation and mutation types. |
| src/components/profile-heading/editor/sections/heading/imagePreview.ts | Adds photo previews and fallbacks. |
| src/components/profile-heading/editor/sections/heading/imageHelpers.ts | Resolves and uploads profile photos. |
| src/components/profile-heading/editor/sections/heading/dateHelpers.ts | Converts display and storage dates. |
| src/components/profile-heading/editor/sections/contactInfo/types.ts | Defines contact data and mutation types. |
| src/components/profile-heading/editor/index.ts | Exports the local heading editor. |
| src/components/navbar/Navbar.ts | Adds pane identity to menu items. |
| src/components/navbar/Navbar.styles.css | Owns navbar spacing and hover styling. |
| src/components/header/Header.styles.css | Adjusts mobile header padding. |
| src/components/file-explorer-header/types.ts | Removes local explorer types. |
| src/components/file-explorer-header/index.ts | Removes local explorer exports. |
| src/components/file-explorer-header/FileExplorerProvider.ts | Removes the local explorer provider. |
| src/components/file-explorer-header/FileExplorerProvider.styles.css | Removes local provider styles. |
| src/components/file-explorer-header/FileExplorerHeaderSummary.ts | Removes the local resource summary. |
| src/components/file-explorer-header/FileExplorerHeaderSummary.styles.css | Removes local summary styles. |
| src/components/file-explorer-header/FileExplorerHeaderControls.ts | Removes local explorer controls. |
| src/components/file-explorer-header/FileExplorerHeaderControls.styles.css | Removes local control styles. |
| src/components/file-explorer-header/FileExplorerHeader.ts | Removes the local explorer header. |
| src/components/file-explorer-header/FileExplorerHeader.styles.css | Removes local explorer-header styles. |
| src/components/editor-card/EditorCard.ts | Passes accessibility metadata to the editor. |
| README.md | Documents navigation, headings, and local development. |
| package.json | Updates dependencies, version, and test preparation. |
Review effort: Balanced
timea-solid
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source pane when editting does not keep its footer during resize.