Repository navigation
rdfxml and n3 accessibility - #811
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The unavailable solid-ui implementation and types prevent verification of the sixth-argument contract and rendered accessibility labels, while the new tests check only host properties.
No open issues 🎉
What changed in this PR
Improves accessibility for generated RDF/XML and N3 views by providing resource-specific labels and read-only descriptions to the shared code editor.
Changes:
- Adds accessible labels and descriptions to both serialization panes.
- Passes accessibility metadata through
EditorCardtoCodeEditor. - Adds unit tests verifying each pane’s content type and accessibility metadata.
| File | Description |
|---|---|
test/unit/rdfSerializationPanes.test.ts |
Tests accessibility metadata for both serialization panes. |
src/RDFXMLPane.ts |
Labels generated RDF/XML with the resource URI and a read-only description. |
src/n3Pane.ts |
Labels generated N3 with the resource URI and a read-only description. |
src/components/editor-card/EditorCard.ts |
Accepts accessibility properties and forwards them during editor initialization. |
Review effort: Balanced
…@5.0.2-8 pane-registry@5.0.2-3 folder-pane@4.0.1-2 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
…@5.0.2-9 pane-registry@5.0.2-3 folder-pane@4.0.1-2 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.