Change for solid-logic after migration to Vite#448
Closed
SharonStrats wants to merge 4 commits into
Closed
Conversation
…/vite-solid-logic
SharonStrats
force-pushed
the
fix/vite-solid-logic
branch
from
July 5, 2026 11:15
d603050 to
eb49de9
Compare
…@3.1.3-9 pane-registry@3.1.2-2 solid-panes@4.4.2-4) (latest: rdflib@2.4.0)
timea-solid
approved these changes
Jul 13, 2026
Contributor
Author
|
After further testing this seems to no longer be needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file is no longer solid-logic it's solid-logic.cjs.js needed to change the package for solid-logic. Perhaps I should have changed to solid-logic.esm.js though?
I made a mistake when commiting the work. i thought i committed it but didn't... anyway in the end i accidently amended the last commit of staging so that's why that file is in here.
I'm not sure what to do or if it matters... i think the commit hash just changed not the content.
Also, I'm not sure how to link this, it needs to merge after this one SolidOS/solid-logic#315 otherwise solidos will stop working when pulling down staging.