Skip to content

Refactor: Error Handling#171

Draft
SharonStrats wants to merge 25 commits into
stagingfrom
refactor/error-handling
Draft

Refactor: Error Handling#171
SharonStrats wants to merge 25 commits into
stagingfrom
refactor/error-handling

Conversation

@SharonStrats
Copy link
Copy Markdown
Contributor

@SharonStrats SharonStrats commented Mar 25, 2026

Remove console logs. Use debug instead. Create a section for errors to inform the user. Add utilsLogic from contacts-pane to show alertDialog for some errors especially when working with an issue.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors error handling/logging in the issue pane UI by introducing a dedicated “Details” section for user-visible errors and routing diagnostic output through a new debug helper.

Changes:

  • Add a “Details” region in issuePane to display errors/warnings to the user.
  • Introduce src/debug.js as a centralized logging wrapper and replace several console.* call sites.
  • Add CSS for the new details section layout/styling and a small shared localUtils helper module.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
src/styles/issuePane.css Adds styling for the new details/error section container and content layout.
src/localUtils.js Introduces helper functions for modal alerts and rendering error blocks.
src/issuePane.js Reworks error reporting to write into a details section and replaces some console logging with debug.
src/debug.js Adds a logging wrapper intended to replace direct console.* usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/issuePane.js
Comment thread src/issuePane.js Outdated
Comment thread src/debug.js
Comment thread src/localUtils.js Outdated
Comment thread src/localUtils.js Outdated
@SharonStrats SharonStrats removed the request for review from timea-solid March 25, 2026 08:45
@SharonStrats SharonStrats marked this pull request as draft March 25, 2026 08:46
@SharonStrats SharonStrats marked this pull request as ready for review March 26, 2026 02:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/localUtils.js Outdated
Comment thread src/localUtils.js Outdated
Comment thread src/newTracker.js Outdated
Comment thread src/csvButton.js Outdated
Comment thread src/csvButton.js Outdated
Comment thread src/issuePane.js Outdated
@timea-solid
Copy link
Copy Markdown
Member

I believe this needs an alignment to the debugging we implemented/agreed up in profile-pane

@SharonStrats SharonStrats marked this pull request as draft May 28, 2026 02:09
@SharonStrats SharonStrats moved this from In review to Backlog in SolidOS NLNet UI May 28, 2026
@SharonStrats SharonStrats force-pushed the refactor/error-handling branch from dffea56 to f3dc9e7 Compare May 31, 2026 06:28
@SharonStrats SharonStrats changed the base branch from refactor/styles-separateCSS to staging May 31, 2026 06:42
@SharonStrats SharonStrats linked an issue May 31, 2026 that may be closed by this pull request
@SharonStrats SharonStrats moved this from Backlog to In progress in SolidOS NLNet UI Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

Improve error handling

3 participants