Fix missing overhang layers with supported counterbore bridging - #677
Open
mwz-iot wants to merge 2 commits into
Open
Fix missing overhang layers with supported counterbore bridging#677mwz-iot wants to merge 2 commits into
mwz-iot wants to merge 2 commits into
Conversation
…x1 only) When support is enabled, the counterbore hole bridging logic in process_no_bridge() keeps the bridge area in the model surface (last), preserving perimeter/overhang wall generation. The full unsupported_filtered is still appended to fill_surfaces for bridge fill coverage. Note: this is fix1 only, the fill/perimeter interference from unsupported_filtered extending into the perimeter zone is not addressed in this commit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rlap when support enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where enabling Counterbore Hole Bridging - Partially Bridged could cause overhang layers that contact support to be missing.
Root cause:
PerimeterGenerator::process_no_bridge()treated the counterbore bridging candidate area as a special fill area and removed it from the original surface (last). Sincelastis later used to generate perimeter and overhang wall paths, removing this area caused the model body overhang layer to disappear when support was enabled.Changes:
unsupported_filteredis no longer removed fromlast, so the original model surface is preserved and perimeter/overhang wall paths can still be generated.fill_surfaces.ext_perimeter_width / 2 + perimeter_spacing * (wall_loops - 1) + perimeter_spacing / 2stInternal; this PR does not change it tostBottomBridge.Screenshots/Recordings/Graphs
Before:
counterbore_hole_bridging = chbBridgesand support enabled, the overhang layer touching support was missing.After:
Tests
Verified with the reproduced 3MF model:
counterbore_hole_bridging = chbNonecounterbore_hole_bridging = chbBridgeswith support enabledSupport disabled with
chbBridgesRecommended regression checks:
chbNoneandchbBridgeson the same Z layer.chbFilledwith support enabled if it shares the same post-processing path.