Show unmatched machine filaments as Generic by material type - #672
Open
doutorinfamous wants to merge 1 commit into
Open
Show unmatched machine filaments as Generic by material type#672doutorinfamous wants to merge 1 commit into
doutorinfamous wants to merge 1 commit into
Conversation
- Introduced a new function `find_compatible_machine_filament_preset` to resolve filament names to local presets, enhancing the user experience by ensuring unmatched brands still appear under the correct machine filament category. - Updated `PlaterPresetComboBox::update` and `TabPresetComboBox::update` methods to utilize the new compatibility function, streamlining the process of matching filament names with their respective presets. - This change improves the handling of filament visibility based on machine nozzle information, ensuring a more intuitive interface for users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a filament loaded on the printer has no exact matching local profile (for example a third-party brand like Voolt3D PLA), it was previously omitted from the Machine Filament list entirely. That made it hard to pick the correct slot and, more importantly, to keep the printer-reported color.
This PR adds a fallback resolution path for Machine Filament entries:
@U1/ nozzle variants), same as before.Generic <filament_type>preset (e.g. PLA →Generic PLA).The matching logic is shared through a small helper used by both
PlaterPresetComboBoxandTabPresetComboBox, so sidebar and Filament tab stay consistent. Exact material-type checks avoid false matches such as PLA vs PLA-CF.Motivation
Color accuracy matters a lot when mapping design filaments to machine slots. Hiding unmatched brands made that workflow worse for any filament without a dedicated Snapmaker profile.
Screenshots/Recordings/Graphs
Before: third-party filaments without a perfect profile match did not appear under Machine Filament.
After: they appear as the matching Generic material profile (e.g. Generic PLA) while preserving the printer color swatch.
Tests