Fix 3MF project-load crash from unavailable plate picker - #671
Open
Ohmicaudio wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nFixes a crash while loading certain 3MF projects.\n\nDuring project reload, a plate picker can be registered before its mesh raycaster has been built. Later mouse picking dereferences that unavailable picker. This adds the same early-return guard used by current upstream OrcaSlicer so unavailable picker meshes are skipped until initialized.\n\n## Validation\n\n- Built Snapmaker_Orca locally in Release with /m:1.\n- Opened drago.3mf and ed+dragon+head+3d+model.3mf with the rebuilt runtime; both remained alive and responsive after load.\n- Change is limited to src/slic3r/GUI/PartPlate.cpp.\n\nNo AMP or surface-color-assist changes are included.