fix: integration tests - #147
Open
tx3stn wants to merge 2 commits into
Open
Conversation
🎉 Bazel & CI Test Results
All Bazel configuration and CI tests passed! ✨ The build system and core tooling are working correctly. 🚀 Bazel remote cache is now enabled - future builds will be faster! Workflow: Valdi CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was trying to add a test for something else, but the integration test suite fails before adding anything.
Runtime_tests.cppcontained the same 261-line block twice — lines 6461-6721 and 6722-6982.Three static helpers (
getTextAttributeValueFromNode,getInlineViewAttachments,inlineViewDynamicSizeViewModel) and sixTEST_Ps, each defined twice causing a compile error, so test_integration and //valdi:test couldn't build at all.Looks like a merge error from d08a134 (merge of PR #121) — its parent has one copy, it has two.
This just deletes those duplicates so the tests run again.
Results (macOS)
//valdi:test_integration//valdi:testThe 17 skips are deliberate GTEST_SKIPs for engine-specific tests on non-matching engines, plus the pre-existing DISABLED_canLockAllJSContexts.
Then in CI the valdi_web Integration Test job failed, which appeared to be because symlinks aren't configured in the run command but are required, so figured I'd fix that too.
Type of Change
Testing
bazel test //...)Testing Details
Checklist