Skip to content

fix: integration tests - #147

Open
tx3stn wants to merge 2 commits into
Snapchat:mainfrom
tx3stn:fix-integration-tests
Open

fix: integration tests#147
tx3stn wants to merge 2 commits into
Snapchat:mainfrom
tx3stn:fix-integration-tests

Conversation

@tx3stn

@tx3stn tx3stn commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Description

I was trying to add a test for something else, but the integration test suite fails before adding anything.

Runtime_tests.cpp contained the same 261-line block twice — lines 6461-6721 and 6722-6982.
Three static helpers (getTextAttributeValueFromNode, getInlineViewAttachments, inlineViewDynamicSizeViewModel) and six TEST_Ps, each defined twice causing a compile error, so test_integration and //valdi:test couldn't build at all.

Looks like a merge error from d08a134 (merge of PR #121) — its parent has one copy, it has two.
This just deletes those duplicates so the tests run again.

Results (macOS)

Target Before After
//valdi:test_integration failed to build PASSED — 1271 ran, 1254 passed, 17 skipped, 0 failed
//valdi:test failed to build PASSED — 2013 ran, 1996 passed, 17 skipped, 0 failed

The 17 skips are deliberate GTEST_SKIPs for engine-specific tests on non-matching engines, plus the pre-existing DISABLED_canLockAllJSContexts.

Then in CI the valdi_web Integration Test job failed, which appeared to be because symlinks aren't configured in the run command but are required, so figured I'd fix that too.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation improvement
  • Performance optimization
  • Test improvement
  • Other (please describe)

Testing

  • Tests pass locally (bazel test //...)
  • Added/updated tests for changes (if applicable)
  • Tested on multiple platforms (iOS/Android/Web/macOS as applicable)
  • Manual testing performed (describe below)

Testing Details

Checklist

  • Code follows project style guidelines
  • Documentation updated (if needed)
  • No breaking changes (or documented in description)
  • Commit messages follow conventional format
  • No secrets, API keys, or internal URLs included

@github-actions

github-actions Bot commented Aug 16, 2026

Copy link
Copy Markdown

🎉 Bazel & CI Test Results

Test Suite Result
Valdi Smoke Tests ✅ success
Linux: Hotreload Smoke ✅ success
Linux: Module Tests ✅ success
macOS: C++ & Platform Tests ✅ success
API Surface Check ✅ success
valdi_web Integration Test ✅ success
Linux: Registry Validation ✅ success
Linux: Build Compiler ✅ success
Snapshot Tests ✅ success
Linux: Build & Export ✅ success
Linux: C++ Tests ✅ success

All Bazel configuration and CI tests passed!

The build system and core tooling are working correctly.

🚀 Bazel remote cache is now enabled - future builds will be faster!

Workflow: Valdi CI

@tx3stn tx3stn changed the title fix: integration tests fix: integration test compile Aug 16, 2026
@tx3stn tx3stn changed the title fix: integration test compile fix: integration tests Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant