file transfer (dotnet): parse images/files, wire directive sink to Rust parity - #348
Merged
Conversation
…st parity Bring the C# smooth-operator server to Rust parity on the PR #342 file-transfer contract. send_message was text-only; it now handles images[], files[], and the send_file directive. - Regenerate Types.cs from the updated spec (adds SendMessageRequest.Files, Skill). - images[]: parsed fail-soft, attached as OpenAI image_url content parts. The engine builds the live user turn from a string, so images ride an image-only ChatMessage seated on the thread just before the text turn (no empty/duplicate message). data: -> DataContent, http(s) -> UriContent; detail on AdditionalProperties. Malformed/unsupported entries dropped. - files[]: parsed fail-soft, surfaced on a new per-turn TurnContext (AsyncLocal) so host tools can read them; never sent to the model. - Directive sink: a host tool writes onto TurnContext.Current.Directive; drained after the turn onto eventual_response.directive (last-write-wins, omitted when none for back-compat). - Tests: FileTransferTests covers images-attach, malformed fail-soft, files-on- context, tool->directive->eventual_response, and directive omission. Source-only; the engine stays the published NuGet (no publish). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: b5438a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The .NET (C#) smooth-operator server handled
send_messageas text only — no multimodal images, no file attachments, and no host-directive channel. The file-transfer contract merged tomainin #342 (send_message.files[]+ thesend_filedirective convention oneventual_response.directive); Rust already implements it. This brings the .NET server to parity.Solution
Types.csfrom the updated spec viatools/Generator(addsSendMessageRequest.Files, and picks upSkill). Generated output, not hand-edited.images[]— parsed fail-soft inFrameDispatcher, attached as OpenAIimage_urlcontent parts. The engine (a fixed published NuGet) builds the live user turn from astring, so it can carry no content parts; instead the images ride an image-onlyChatMessageseated on the thread immediately before the text turn — the model sees them adjacent to the question, with no empty or duplicated message.data:→DataContent,http(s)→UriContent; the optional visiondetailhint rides onAdditionalProperties. Malformed/unsupported entries are dropped.files[]— parsed fail-soft and surfaced on a new per-turnTurnContext(files list + directive sink), published as anAsyncLocalaround the run so a host tool the engine invokes can read them. Never sent to the model.send_filedirective — a host tool writes an opaque directive ontoTurnContext.Current.Directive; the runner drains it after the turn ontoeventual_response.directive(last-write-wins, omitted when none for back-compat).ProtocolEvents.EventualResponsegrew an optionaldirectiveparam.Backward compatible: absent
images/filesand no host directive is byte-for-byte the previous text-only behavior.Verification
dotnet build+dotnet teston the full solution in Release: all green (302 server tests incl. 8 new, plus integration/host/client/postgres projects).FileTransferTests(8): images attach as content parts (UriContent+DataContent,detailonAdditionalProperties, live text turn preserved, no empty message), malformed images fail-soft, files surfaced onTurnContextand kept off the model, tool→directive→eventual_response.directive(spec-validated), and directive omission for back-compat.Notes
SmooAI.SmoothOperator.CoreNuGet; this PR does not publish anything.minoron@smooai/smooth-operator-server).🤖 Generated with Claude Code