Skip to content

Matter Window Covering: Ignore unchanged handling, stop motion on inverted scroll #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hcarter-775 wants to merge 1 commit into
base: bugfix/report-movement-while-moving
Choose a base branch
from
+24 −11
Open

Matter Window Covering: Ignore unchanged handling, stop motion on inverted scroll #3145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 24 additions & 11 deletions drivers/SmartThings/matter-window-covering/src/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,22 +284,35 @@ local function handle_shade_level(driver, device, cmd)
end

local function handle_step_shade_level(driver, device, cmd)
local step = cmd.args.stepSize
local latest_lift_percentage = device:get_latest_state(
local step = cmd.args.stepSize or 0
local latest_lift = device:get_latest_state(
"main",
capabilities.windowShadeLevel.ID,
capabilities.windowShadeLevel.shadeLevel.NAME,
0
)
local target_lift_percent = device:get_field(TARGET_LIFT_PERCENT.STATE) or latest_lift_percentage
local updated_target_lift = utils.clamp_value(target_lift_percent + step, 0, 100)
cache_data_with_timeout(device, updated_target_lift, TARGET_LIFT_PERCENT)
driver:inject_capability_command(device, {
capability = capabilities.windowShadeLevel.ID,
component = cmd.component,
command = capabilities.windowShadeLevel.commands.setShadeLevel.NAME,
named_args = { shadeLevel = updated_target_lift }
})
local target_lift = device:get_field(TARGET_LIFT_PERCENT.STATE) or latest_lift
local updated_target_lift = utils.clamp_value(target_lift + step, 0, 100)
if step == 0 or target_lift == updated_target_lift then
-- no change in targeting, exit handler
return
elseif (target_lift > latest_lift and step < 0) or (target_lift < latest_lift and step > 0) then
-- target direction altered, pause motion to reset cached state and targeting.
driver:inject_capability_command(device, {
capability = capabilities.windowShade.ID,
component = cmd.component,
command = capabilities.windowShade.commands.pause.NAME,
args = {}
})
else
-- standard motion adjustment
driver:inject_capability_command(device, {
capability = capabilities.windowShadeLevel.ID,
component = cmd.component,
command = capabilities.windowShadeLevel.commands.setShadeLevel.NAME,
named_args = { shadeLevel = updated_target_lift }
})
end
end

-- move to shade tilt level between 0-100
Expand Down
Loading