WWSTCERT-10832 - add aeotec 8 series new by iot-holding · Pull Request #2897 · SmartThingsCommunity/SmartThingsEdgeDrivers

iot-holding · 2026-04-13T13:40:00Z

Check all that apply

Type of Change

[ x] WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
[x ] New feature
Refactor

Checklist

[x ] I have performed a self-review of my code
I have commented my code in hard-to-understand areas
[ x] I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This is a new clean pull request for the new Aeotec Series 8 devices.

Summary of Completed Tests

github-actions · 2026-04-13T13:40:35Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2026-04-13T13:42:31Z

Test Results

72 files 503 suites 0s ⏱️
2 777 tests 2 777 ✅ 0 💤 0 ❌
4 680 runs 4 680 ✅ 0 💤 0 ❌

Results for commit 7af6533.

♻️ This comment has been updated with latest results.

github-actions · 2026-04-13T13:42:33Z

File	Coverage
All files	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/aeotec-aerq-8/init.lua	`50%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/apiv6_bugfix/init.lua	`77%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/aeotec-multisensor/multisensor-7/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/configurations.lua	`99%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/init.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/enerwave-motion-sensor/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/aeotec-door-window-sensor-8/init.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/aeotec-multisensor/multisensor-6/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/aeotec-water-sensor-8/init.lua	`35%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/sensative-strip/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/homeseer-multi-sensor/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-sensor/src/wakeup-no-poll/init.lua	`92%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7af6533

github-actions · 2026-04-13T13:42:40Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/BxlrE7X91k2P

cjswedes · 2026-04-14T19:12:40Z

+    MATCHING_MATRIX = {
+      mfrs = 0x0371,
+      product_types = {0x0002, 0x0102, 0x0202},
+      product_ids = 0x0018


This is different than what is in the fingerprint. Please double check the product ids for all devices.

cjswedes · 2026-04-14T19:15:48Z

+    preferenceType: integer
+    definition:
+      minimum: 0
+      maximum: 2678400


This is higher than what the preference allows. Check the parameter definitions in preferences.lua and change the size to what it should be or update this to match the size of parameter 1.

cjswedes · 2026-04-14T19:23:26Z

+end
+
+local function do_refresh(driver, device)
+  device:send(Battery:Get({}))


Why not use the default functionality for refresh? This will also read state from the command classes that support the devices capabilities rather than just battery.

cjswedes · 2026-04-14T19:24:02Z

+      default: 0
+  - name: "parameter13"
+    title: "13 Mold alarm offset"
+    desccription: "Increase the humidity threshold."


Suggested change

desccription: "Increase the humidity threshold."

description: "Increase the humidity threshold."

cjswedes · 2026-04-14T19:24:16Z

+      default: 0
+  - name: "parameter13"
+    title: "13 Mold alarm offset"
+    desccription: "Increase the humidity threshold."


Suggested change

desccription: "Increase the humidity threshold."

description: "Increase the humidity threshold."

cjswedes · 2026-04-14T19:28:29Z

This file has bytes on the end of the name that make it hidden to require. It is likely the main cause of the widespread test failures

cjswedes · 2026-04-14T19:29:55Z

+  device:send(Battery:Get({}))
+
+  device:register_native_capability_attr_handler("temperatureMeasurement", "temperature")
+  -- device:register_native_capability_attr_handler("colorControl", "hue")


Remove commented out code.

cjswedes · 2026-04-14T19:32:28Z

+  can_handle = can_handle_aeotec_aerq
+}
+
+return aeotec_aerq_8


Add newline to end of this file and any other files that have it missing.

cjswedes · 2026-04-14T19:35:25Z

This subdriver is unnecessary. The aeotec-door-window-sensor-8 handlers cover everything here. Remove this driver, and have the device be handled by that one.

cjswedes · 2026-04-14T19:37:33Z

I will re-review once the tests are passing.

Ill also request that you test your device on a real hub to ensure its functionality is what you expect.

cjswedes · 2026-04-20T16:36:52Z

Rename this file to be .lua there are hidden characters that will make require fail.

cjswedes · 2026-04-20T16:38:47Z

This file must also have a weird name

cjswedes · 2026-04-20T16:40:29Z

+  },
+  AEOTEC_AERQ_8 = {
+    mfrs = 0x0371,
+    product_ids = 0x0018


Wrong product ID?

new pull request

a51d695

Update preferences.lua

a59dd3e

iot-holding changed the title ~~new pull request~~ add aeotec 8 series Apr 14, 2026

iot-holding changed the title ~~add aeotec 8 series~~ add aeotec 8 series new Apr 14, 2026

cbaumler requested review from aleclorimer and cjswedes April 14, 2026 15:52

cjswedes requested changes Apr 14, 2026

View reviewed changes

KKlimczukS changed the title ~~add aeotec 8 series new~~ WWSTCERT-10832 - add aeotec 8 series new Apr 15, 2026

mh-zwave added 2 commits April 16, 2026 11:26

update

6645186

Update test_aeotec_aerq_8.lua‎

e89ca64

cjswedes reviewed Apr 20, 2026

View reviewed changes

fix wrong product_id for aerq 8

7af6533

	desccription: "Increase the humidity threshold."
	description: "Increase the humidity threshold."

Conversation

iot-holding commented Apr 13, 2026

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjswedes commented Apr 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Apr 13, 2026 •

edited

Loading

github-actions Bot commented Apr 13, 2026 •

edited

Loading