Validate automatic URLs - #8813
Merged
Merged
Conversation
APickledWalrus
requested review from
Pesekjak and
cheeezburga
and removed request for
a team
August 4, 2026 18:36
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
skriptlang-automation
Bot
added
bug
Efnilite
reviewed
Aug 12, 2026
sovdeeth
approved these changes
Aug 16, 2026
Efnilite
approved these changes
Aug 17, 2026
github-project-automation
Bot
moved this from In Review
to Awaiting Merge
in 2.16 Releases
skriptlang-automation
Bot
added
patch-ready
skriptlang-automation
Bot
added
the
completed
github-project-automation
Bot
moved this from Awaiting Merge
to Done - Awaiting Release
in 2.16 Releases
skriptlang-automation
Bot
removed
the
patch-ready
APickledWalrus
moved this from Done - Awaiting Release
to Done - Released
in 2.16 Releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The automatic link parsing in strings (enabled via config) does not validate whether the matched content is actually a valid URL. Thus, an exception occurs, which can cascade into other failures.
Solution
Validates that the content is a valid URL before parsing. Attempts recovery if possible (not sure if this is the right idea? I'd like opinions).
Testing Completed
Added a JUnit test case
Supporting Information
Completes: none (reported on Discord)
Related: none
AI assistance: none