Feat: Shared security storage 2nd try o.o - #537
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9ba7732f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ConfigUtils.normalizeServerConfig(serverConfig); | ||
| ServerSecurityPathManager.configure(serverConfig); |
There was a problem hiding this comment.
When sharedSecurity.enabled remains at its default false, this replacement removes the standalone server's previous serverConfig.validateSecrets = false behavior. Server.main has no login path that issues local secrets, so the local secret store remains empty and every download request is rejected by Secrets.isSecretValid; keep validation disabled for non-shared standalone hosts while allowing shared-mode hosts to validate records issued elsewhere.
Useful? React with 👍 / 👎.
|
|
||
| @Test | ||
| void multipleJvmWorkersMergeIntoOneStore() throws Exception { | ||
| String java = Path.of(System.getProperty("java.home"), "bin", "java.exe").toString(); |
There was a problem hiding this comment.
On Linux and macOS, ${java.home}/bin/java.exe does not exist, so this test throws while starting its first worker. The repository's Ubuntu build job runs ./gradlew build in .github/workflows/build.yml, which includes core:test, making the normal Linux build fail; choose java.exe only on Windows and java elsewhere.
Useful? React with 👍 / 👎.
| } catch (Exception exception) { | ||
| LOGGER.warn("Shared security validation failed closed: {}", exception.getMessage()); | ||
| return false; |
There was a problem hiding this comment.
When shared storage times out, is unavailable, or fails validation, this catch always rejects authentication even if the newly documented sharedSecurity.failClosed option is set to false. Since failClosed() is otherwise never read, changing that setting has no effect and operators selecting the availability-oriented behavior still experience a complete download outage.
Useful? React with 👍 / 👎.
|
how tf this works, i dont see this review on my dashboard and i dont even have tokens on this account, does it go through you? xdd |
Wow! i didn’t know this existed in chatgpt |
2 participants
No description provided.