gen/shared storage - #526
Open
Skidamek wants to merge 14 commits into
Open
Conversation
Remove refresh from the wire protocol, share frame and pipeline handling, centralize generation publication and login state, and promote verified CAS objects through a target-local temporary file when storage roots use different filesystems.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73dbc8afac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR separates shared client data from the active game directory and unifies the transfer paths.
DataRootResolver chooses and pins a shared operating-system data root, with a game-local fallback. ClientStorage keeps the active projection and transaction state with the game while shared objects, generation records, caches, pack connections, and origin trust data use the resolved root. Overlay tombstones and their digest are stored with the client state.
Server generation storage now has explicit records, catalogues, commits, deltas, current state, and compaction. The store can measure and collect unreferenced objects, preserve patch-note history, and repair a missing current projection. Standalone servers use the same storage layout.
ProtocolFrameCodec provides one length and compression codec for blocking and Netty transfers. ProtocolPipeline installs the same Netty handlers for regular and holepunch connections. Downloads validate sizes and hashes, and trust data is keyed by connection origin instead of a raw IP address.
The client, standalone server, and update screens use the new roots and transfer code. Preload acquires selected objects without changing the active projection.
Coverage
The layer adds shared-storage, cache-collection, protocol, trust, standalone-server, and download tests.