gen/domain foundation - #524
Open
Skidamek wants to merge 23 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ed16b43e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the generation model that the later client and lifecycle layers use.
A generation is an immutable record with a canonical SHA-1 identity, a parent, selected groups, file metadata, and patch notes. GenerationStore validates referenced objects and the parent chain before it publishes the current generation. Publication uses an expected-current check, a process and file lock, verified staged objects, and an atomic current-pointer write.
The candidate scanner reads explicit group directories and synchronized server roots. It records source paths, excluded and shadowed files, and stable file metadata. The group resolver adds required groups and dependencies, rejects incompatible or conflicting selections, and produces a deterministic selected tree.
The ownership ledger keeps the history of each logical path. It records object hashes, the first and last generation that used a path, and PRESENT or TOMBSTONE state. Update planning uses that ledger to plan managed deletion, nested mod copies, duplicate mod handling, editable-file preservation, and local-only changes.
Coverage
The layer adds tests for generation identity and publication, candidate scanning, group resolution, ownership reconstruction, and update planning.