Skip to content

Fix output record paths to avoid tombstone reuse - #38

Merged
JimBobSquarePants merged 2 commits into
mainfrom
js/fix-vertex-list
Jul 17, 2026
Merged

Fix output record paths to avoid tombstone reuse#38
JimBobSquarePants merged 2 commits into
mainfrom
js/fix-vertex-list

Conversation

@JimBobSquarePants

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This pull request makes a minor update to the Add method in VertexPoolList.cs to ensure the Path property of outputRecord is properly initialized before it is cleared. This helps prevent potential null reference issues.

  • Ensures outputRecord.Path is set to an empty list if it has the special Tombstone value before calling Clear() on it.

Ensure pooled output records replace tombstone path instances before clearing them, avoiding reuse of the sentinel collection.
@JimBobSquarePants JimBobSquarePants added the bug Something isn't working label Jul 17, 2026
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73%. Comparing base (7ef6c62) to head (dba6a00).

Files with missing lines Patch % Lines
src/PolygonClipper/VertexPoolList.cs 0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main    #38   +/-   ##
===================================
- Coverage    73%    73%   -1%     
===================================
  Files        30     30           
  Lines      3595   3596    +1     
  Branches    866    867    +1     
===================================
  Hits       2654   2654           
  Misses      718    718           
- Partials    223    224    +1     
Flag Coverage Δ
unittests 73% <0%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JimBobSquarePants
JimBobSquarePants merged commit 3100541 into main Jul 17, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant