Validate PBM max pixel value#3134
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #3130
This pull request adds stricter validation for the PBM image decoder to ensure that only valid max pixel values are accepted, and introduces corresponding tests to verify this behavior.
Decoder validation improvement:
PbmDecoderCore.csto throw anInvalidImageContentExceptionifmaxPixelValueis less than or equal to 0 or greater than or equal to 65536, preventing invalid PBM images from being processed.Test coverage:
PbmDecoderTests.csto verify that decoding PBM images with a max pixel value of 0 for all supported magic numbers throws anInvalidImageContentException.