You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, thanks for your contribution.
However, there are a few issues in your pull request:
File breaking
l4d2_skill_detect
CalarmTouchedJockey phrase is missing its closing quote.
blocktrolls
Every phrase uses "en" as the language key with Chinese translations.
Non-existing translations, you probably based your translations on a different version of the translations/plugins.
l4d2_tank_horde_monitor
4 of 6 keys don't exist here (HordePaused, WarningPercent, StrenthPercent, 100PercentStrenth)
This repository renamed them to TankPlay, UntilHordeStarts, HordeStrength, HordeVeryStrength.
The translations are fine, they just need the keys renamed.
It also has duplicated "en" lines that should be deleted.
pause
4 *Initiator variants aren't used in the plugin.
l4d2_stats
assister, AssistShotsSingular, AssistShotsPlural are not used.
l4d_boss_vote
RoundNotReachLimit is not used.
Also uses an "en" key and contains a random joke: "您这个难度就想马上逃课了?"
playermanagement
Print_Move_Spectator is not used.
1v1
AI is not used.
Format issues
l4d2_skill_detect
9 phrases changed {N:t} to {N:s}
:t is what makes them translate per-client.
You translate those words, then breaks the mechanism that would use them by using a raw string.
1v1
Healthremaining is changed from {1:N} to 1:s}, the plugin passes a client index, not a name.
Other issues
pause
You added [!] into the phrases, but the plugin already has them hardcoded meaning messages will show up with [!] [!] rather than just one.
18 of the base phrases are not translated.
Hi sirplease,
I found a new issue. In your original translation,
"HealthRemaining"
{
"#format" "{1:N},{2:s},{3:d}" // 1:iAttacker 2:L4D2_InfectedNames[iZclass] 3:iRemainingHealth
"en" "{red}{1}{default} ({green}{2}{default}) had {olive}{3}{default} health remaining!"
}
However, this causes the name to not display. The actual effect looks like this: [1v1] (Hunter) had 250 health remaining!
In my latest Chinese translation version, I have already fixed this issue.
You only need to change 1:iAttacker to 1:sName, and that's it.
"Fixed version:
[1v1] 死亡中心最菜传说(Hunter) had 250 health remaining!"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just Add Chinese translations Test on myserver 202.189.15.5:30001