Skip to content

Allow seekTo to go to millisecond rather than floored second #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattbajorek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow seekTo to go to millisecond rather than floored second #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/Classes/AudioPlayer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class AudioPlayer: NSObject, AVAudioPlayerDelegate {

func seekTo(_ time: Int?, _ result: @escaping FlutterResult) {
if(time != nil) {
player?.currentTime = Double(time! / 1000)
player?.currentTime = TimeInterval(time! / 1000)

Copilot AI Oct 11, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integer division time! / 1000 still occurs before the TimeInterval conversion, which means millisecond precision is still lost due to integer truncation. Convert to TimeInterval first, then divide: player?.currentTime = TimeInterval(time!) / 1000.0

Suggested change
player?.currentTime = TimeInterval(time! / 1000)
player?.currentTime = TimeInterval(time!) / 1000.0

Copilot uses AI. Check for mistakes.

@aditya-css aditya-css Oct 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattbajorek Please see this.

@lavigarg-simform lavigarg-simform Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't change the behavior. TimeInterval is just a typealias for Double, so this is the same as the original Double(time! / 1000).

The problem is time! / 1000 runs first as integer division (both are Int), so the milliseconds get truncated before the conversion. Seek still floors to the nearest second.

Cast first, then divide:

player?.currentTime = Double(time!) / 1000

For time = 1500: current gives 1.0s, this gives 1.5s.

sendCurrentDuration()
result(true)
} else {
Expand Down