add read tool formatters#1016
Open
LasmarKhalifa wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 2, 2026
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
from
af63b1e to
1522547
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-bash
branch
from
d2b7c43 to
3ee55e7
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
from
1522547 to
2162423
Compare
LasmarKhalifa
requested review from
dersam,
juniper-shopify,
mathiusj and
nfgrep
as code owners
mathiusj
approved these changes
Jul 3, 2026
mathiusj
reviewed
Jul 3, 2026
mathiusj
left a comment
mathiusj
left a comment
Contributor
There was a problem hiding this comment.
read formatters look good. Two edge/consistency notes.
mathiusj
approved these changes
Jul 3, 2026
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
from
2162423 to
9774c62
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-bash
branch
from
3ee55e7 to
542e96a
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
from
9774c62 to
eecfae1
Compare
LasmarKhalifa
force-pushed
the
06-30/pi-tool-formatter-read
branch
from
eecfae1 to
daeaf21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1024