fix: guard ViewHolderCollection against out-of-bounds index on shrink - #2458
Open
ErfanBagheri404 wants to merge 1 commit into
Open
fix: guard ViewHolderCollection against out-of-bounds index on shrink#2458ErfanBagheri404 wants to merge 1 commit into
ErfanBagheri404 wants to merge 1 commit into
Conversation
The render stack may still hold indices from a previous, larger data set while the layout table has already been resized by a shrink. getLayout(index) then throws. Skip entries whose index exceeds data.length so the stale render stack drains harmlessly. Fixes Shopify#2440
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2440
The render stack may still hold indices from a previous, larger data set while the layout table has already been resized by a shrink.
getLayout(index)then throws atLayoutManager:232. Guard the render path so stale entries drain harmlessly instead of crashing.Early-return
nullfor entries whoseindex >= data.lengthbeforegetLayout/isInLastRoware called.