Remove stored auth test storage casts#8106
Open
alfonso-noriega wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/992f9535-2b53-46c8-a775-0fc7a7bc2eb5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Fixes none.
The stored auth summary tests repeated
storage as anycasts, which obscured the intended test storage type and made malformed-storage setup harder to distinguish from normal typed calls.WHAT is this pull request doing?
Adds typed test helpers for store-auth local storage and raw malformed bucket setup, then replaces the repeated
as anycasts instored-auth.test.ts.How to test your changes?
pnpm --filter @shopify/store vitest run src/cli/services/store/auth/stored-auth.test.tspnpm --filter @shopify/store lintNote:
pnpm --filter @shopify/store type-checkwas attempted locally but failed on existing@shopify/organizationsmodule resolution errors unrelated to this test-only diff.Post-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add