[Tests] Add unit tests for flushPromises utility#8062
Conversation
Adds comprehensive unit tests for the `flushPromises` utility in `@shopify/cli-kit`. Covers microtasks, nested microtasks, and macrotasks (setImmediate).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Merge activity
|
WHY are these changes introduced?
The
flushPromisesutility in@shopify/cli-kitwas identified as lacking dedicated unit tests. Adding these tests ensures the utility correctly handles various asynchronous scenarios, making the codebase safer to change.WHAT is this pull request doing?
Introduces
packages/cli-kit/src/public/node/promises.test.tswhich tests:setImmediate.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 10896329056256182399 started by @gonzaloriestra