Make deploy consumers speak app-module UUID/registration-ID maps#8047
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 9, 2026
github-actions
Bot
added
the
no-changelog
This was referenced Jul 10, 2026
isaacroldan
force-pushed
the
deploy-split/04-deploy-identifiers-shape
branch
from
0e761f5 to
7f5da67
Compare
isaacroldan
force-pushed
the
deploy-split/03-webhook-subscription-uid
branch
from
e455880 to
9ecd55c
Compare
isaacroldan
force-pushed
the
deploy-split/04-deploy-identifiers-shape
branch
from
7f5da67 to
8e14666
Compare
isaacroldan
force-pushed
the
deploy-split/03-webhook-subscription-uid
branch
from
9ecd55c to
87d7b77
Compare
isaacroldan
force-pushed
the
deploy-split/04-deploy-identifiers-shape
branch
from
8e14666 to
d1ec8fa
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/object.d.ts@@ -38,6 +38,14 @@ export declare function mapValues<T extends object, TResult>(source: T | null |
* @returns True if the objects are equal, false otherwise.
*/
export declare function deepCompare(one: object, two: object): boolean;
+/**
+ * Deeply compares two values and treats arrays as order-insensitive.
+ *
+ * @param one - The first value to be compared.
+ * @param two - The second value to be compared.
+ * @returns True if the normalized values are equal, false otherwise.
+ */
+export declare function deepCompareWithOrderInsensitiveArrays(one: unknown, two: unknown): boolean;
/**
* Return the difference between two nested objects.
*
|
Introduces `ExtensionUuidsByLocalIdentifier` and `DeployIdentifiers` and switches the manifest and bundling consumers to plain UUID-by-local-identifier maps: `app.manifest`, `ExtensionInstance.bundleConfig`, and `bundleAndBuildExtensions` no longer take the full `Identifiers` object (the always-undefined dev-dashboard `outputId` plumbing is removed with it). `deploy` still derives identifiers from the existing matching flow and adapts them into these maps, so behavior is unchanged. Later commits replace the matching flow itself. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
isaacroldan
force-pushed
the
deploy-split/04-deploy-identifiers-shape
branch
from
d1ec8fa to
fc1a187
Compare
isaacroldan
force-pushed
the
deploy-split/03-webhook-subscription-uid
branch
from
87d7b77 to
d3fd852
Compare
alfonso-noriega
approved these changes
Jul 10, 2026
| // Ideally we want to return `this.uid` always. To keep supporting Partners API we accept a value to override that. | ||
|
|
||
| return outputId ?? this.uid | ||
| getOutputFolderId() { |
alfonso-noriega
approved these changes
Jul 10, 2026
Base automatically changed from
deploy-split/03-webhook-subscription-uid
to
main
July 10, 2026 15:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Groundwork for replacing the identifier-matching flow. The bundling and upload path took the whole legacy
Identifiersobject; decoupling it to plain UUID-by-local-identifier maps lets the new flow (#8055/#8056) supply identifiers without that structure.WHAT is this pull request doing?
ExtensionUuidsByLocalIdentifierandDeployIdentifiers.app.manifest,ExtensionInstance.bundleConfig, andbundleAndBuildExtensionsto plain UUID maps, dropping the always-undefineddev-dashboardoutputIdplumbing.deploystill derives identifiers from the existing matching flow and adapts them into the new maps.Behavior-preserving refactor.
How to test your changes?
pnpm --filter @shopify/app exec vitest run src/cli/services/deploy src/cli/models/app src/cli/models/extensions