Fix function extension build path and info output path resolution#7244
Merged
isaacroldan merged 2 commits intomainfrom Apr 10, 2026
Merged
Conversation
Co-authored-by: Claude Code <claude-code@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes function output path resolution by honoring build.path from the function TOML configuration in both function info output and function build/rebundle behavior.
Changes:
- Extend function info formatting to compute
wasmPathfromconfig.build.path(fallback to defaultoutputRelativePath). - Update function build logic to avoid base64 rebundling when building locally and the bundle path matches the project’s default output path.
- Add/adjust tests to validate
wasmPathbehavior in JSON output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/app/src/cli/services/function/info.ts | Compute and display function wasm/output path using build.path (or default). |
| packages/app/src/cli/services/function/info.test.ts | Adds tests for build.path wasmPath behavior; updates helper function signatures. |
| packages/app/src/cli/services/build/extension.ts | Skips base64 rebundling when bundle path equals the project’s default output path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Claude Code <claude-code@anthropic.com>
6e7c17a to
8283c0a
Compare
alfonso-noriega
approved these changes
Apr 10, 2026
gonzaloriestra
approved these changes
Apr 10, 2026
Contributor
gonzaloriestra
left a comment
There was a problem hiding this comment.
Tested that it works as expected 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Fixes https://community.shopify.dev/t/cli-3-93-0-regression-vitest-wasm-tests-fail-for-rust-function-extensions-base64-written-to-dist-index-wasm-instead-of-raw-binary/33061
The
function infocommand was printing the wrongwasmPath.It should be read from the toml config and not default to
extension.outputPathAlso, during build we need to make sure to only do the base64 conversion when the
bundlePathis really different from the outputPath.WHAT is this pull request doing?
build.pathconfiguration in function configurations by extending theFunctionConfigurationinterfacebuild.pathor falling back to the defaultoutputRelativePathHow to test your changes?
build.pathin its configurationChecklist
pnpm changeset add